xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix: staging test_asset.spec.ts 适配 POST /assets 返回 410 #1453

Merged
auto-approve-bot merged 1 commits from fix/staging-tests-410-assets into develop 2026-08-21 00:06:01 +08:00
Conversation 5 Commits 1 Files Changed 1
+31 -39
xiaoxia commented 2026-08-20 23:26:48 +08:00
Owner
Copy Link
Copy Source

问题

staging API 集成测试仍调用 POST /api/v1/assets 创建素材，该接口已废弃返回 410 Gone。

修复

  • 创建素材记录测试：改为验证 POST /assets 返回 410 + error.code=HTTP_410
  • 列出素材测试：改用 POST /upload (multipart upload) 创建测试素材，替代直接调废弃接口

仅 staging E2E 测试文件，无业务代码变更。

## 问题 staging API 集成测试仍调用 POST /api/v1/assets 创建素材，该接口已废弃返回 410 Gone。 ## 修复 - 创建素材记录测试：改为验证 POST /assets 返回 410 + error.code=HTTP_410 - 列出素材测试：改用 POST /upload (multipart upload) 创建测试素材，替代直接调废弃接口 仅 staging E2E 测试文件，无业务代码变更。
gitea-actions bot commented 2026-08-20 23:28:35 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1453
预览链接 https://pr-1453.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1453 | | 预览链接 | [https://pr-1453.preview.xiaoxiajianji.com](https://pr-1453.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot approved these changes 2026-08-20 23:40:30 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-08-20 23:40:30 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
xiaoxia added 1 commit 2026-08-20 23:55:01 +08:00
fix: staging test_asset.spec.ts 适配 POST /assets 返回 410
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 47s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m43s
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 2m40s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 2m50s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m12s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m58s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 3m15s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m28s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 2m40s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 3m4s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 9m59s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 10s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 54s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 1m15s
Details
187ab9f60b 
- 创建素材记录测试：改为验证 POST /assets 返回 410 + error.code=HTTP_410
- 列出素材测试：改用 POST /upload (multipart upload) 创建测试素材，替代废弃接口
auto-approve-bot commented 2026-08-20 23:57:58 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #1453

⚠️ 问题（0个需要修改）

无

💡 建议（0个可选）

无

✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：通过
  • 建议级问题数量：0 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

无

✅ 良好实践

  1. 测试用例更新及时：将“创建素材”的测试用例准确更新为验证废弃接口返回 410 状态码，确保了测试与后端 API 变更的一致性。
  2. 异步处理优化：在“列出素材”测试中，使用轮询机制（Polling）替代了简单的静态等待，有效解决了异步 ingest job 导致的测试不稳定性问题。
  3. Mock 数据真实化：使用真实的 Buffer 数据和 multipart/form-data 格式进行上传测试，比之前的 Mock 数据更能验证端到端的集成能力。
  4. 边界检查：在轮询逻辑中正确处理了 items 可能为空的情况（data.items || []），避免了潜在的空指针异常。

🤖 由 AI 代码审查机器人自动生成 | 2026-08-20 15:57:57 | 模型:

## 代码审查结果 - PR #1453 ### ⚠️ 问题（0个需要修改） 无 ### 💡 建议（0个可选） 无 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好 ### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：通过 - 建议级问题数量：0 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 无 ### ✅ 良好实践 1. **测试用例更新及时**：将“创建素材”的测试用例准确更新为验证废弃接口返回 410 状态码，确保了测试与后端 API 变更的一致性。 2. **异步处理优化**：在“列出素材”测试中，使用轮询机制（Polling）替代了简单的静态等待，有效解决了异步 ingest job 导致的测试不稳定性问题。 3. **Mock 数据真实化**：使用真实的 Buffer 数据和 multipart/form-data 格式进行上传测试，比之前的 Mock 数据更能验证端到端的集成能力。 4. **边界检查**：在轮询逻辑中正确处理了 `items` 可能为空的情况（`data.items || []`），避免了潜在的空指针异常。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-20 15:57:57 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
auto-approve-bot merged commit b7be479ae7 into develop 2026-08-21 00:06:01 +08:00
auto-approve-bot deleted branch fix/staging-tests-410-assets 2026-08-21 00:06:02 +08:00
gitea-actions bot commented 2026-08-21 00:07:15 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1453 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1453 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1453
Delete Branch "fix/staging-tests-410-assets"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?