xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix(e2e): update generation API URL pattern in core-generation test #1455

Merged
auto-approve-bot merged 1 commits from fix/e2e-generation-url-pattern into develop 2026-08-21 12:31:01 +08:00
Conversation 5 Commits 1 Files Changed 1
+2 -3
xiaoxia commented 2026-08-21 12:07:27 +08:00
Owner
Copy Link
Copy Source

问题

Staging E2E Tests 中 core-generation.spec.ts:55 的 walks through 7-step wizard and starts generation 测试持续失败，原因是 page.waitForResponse 等待 30s 超时。

根因：waitForResponse 匹配的是 POST /confirm 或 POST /editor/generate，但前端实际调用的是 POST /generation/tasks，URL 永远匹配不上，导致超时失败。

最近 5 次 develop push 的 Staging E2E Tests 全部因此失败。

修复

将 URL 匹配条件改为 path.endsWith("/generation/tasks")，与前端实际 API 一致。

验收标准

  • E2E 测试 core-generation.spec.ts:55 的 waitForResponse 匹配正确的 API 路径
  • CI 通过，Staging E2E Tests 变绿
## 问题 Staging E2E Tests 中 `core-generation.spec.ts:55` 的 `walks through 7-step wizard and starts generation` 测试持续失败，原因是 `page.waitForResponse` 等待 30s 超时。 **根因**：`waitForResponse` 匹配的是 `POST /confirm` 或 `POST /editor/generate`，但前端实际调用的是 `POST /generation/tasks`，URL 永远匹配不上，导致超时失败。 最近 5 次 develop push 的 Staging E2E Tests 全部因此失败。 ## 修复 将 URL 匹配条件改为 `path.endsWith("/generation/tasks")`，与前端实际 API 一致。 ## 验收标准 - [x] E2E 测试 `core-generation.spec.ts:55` 的 waitForResponse 匹配正确的 API 路径 - [ ] CI 通过，Staging E2E Tests 变绿
xiaoxia added 1 commit 2026-08-21 12:07:28 +08:00
fix(e2e): update generation API URL pattern in core-generation test
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 45s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 46s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m37s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m42s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m22s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m8s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m44s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 2m40s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 7m6s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 7m58s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 19m3s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 8s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 42s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 1m14s
Details
6b34acff3f 
The waitForResponse was matching POST /confirm or /editor/generate,
but the frontend actually calls POST /generation/tasks directly.
This caused the 30s timeout to fire and the test to fail.

Updated the URL matcher to match path.endsWith('/generation/tasks').
auto-approve-bot commented 2026-08-21 12:09:05 +08:00
Collaborator
Copy Link
Copy Source

【阻塞级判定】

  • 是否存在阻塞级问题：否
  • 阻塞级问题数量：0 个

📊 审查概览

  • 整体评价：通过
  • 建议级问题数量：0 个

🔴 阻塞级问题（必须修复）

无

💡 改进建议（不阻塞合并）

无

✅ 良好实践

  1. [apps/web/e2e/core-generation.spec.ts] 注释与代码同步更新
    • 具体内容：在修改 API 路径匹配逻辑的同时，准确更新了上方注释，说明了新的前端交互流程（“前端直接创建生成任务”），这有助于其他开发者理解测试意图及业务变更。

🤖 由 AI 代码审查机器人自动生成 | 2026-08-21 04:09:05 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题：否 - 阻塞级问题数量：0 个 ### 📊 审查概览 - 整体评价：通过 - 建议级问题数量：0 个 ### 🔴 阻塞级问题（必须修复） 无 ### 💡 改进建议（不阻塞合并） 无 ### ✅ 良好实践 1. **[apps/web/e2e/core-generation.spec.ts] 注释与代码同步更新** - 具体内容：在修改 API 路径匹配逻辑的同时，准确更新了上方注释，说明了新的前端交互流程（“前端直接创建生成任务”），这有助于其他开发者理解测试意图及业务变更。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-21 04:09:05 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
auto-approve-bot approved these changes 2026-08-21 12:09:39 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-08-21 12:09:39 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
gitea-actions bot commented 2026-08-21 12:10:10 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1455
预览链接 https://pr-1455.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1455 | | 预览链接 | [https://pr-1455.preview.xiaoxiajianji.com](https://pr-1455.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot merged commit 955613efd3 into develop 2026-08-21 12:31:01 +08:00
auto-approve-bot deleted branch fix/e2e-generation-url-pattern 2026-08-21 12:31:01 +08:00
gitea-actions bot commented 2026-08-21 12:32:14 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1455 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1455 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1455
Delete Branch "fix/e2e-generation-url-pattern"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?