xiaoxia/xiaoxia-saas

fix(cover): extract cover from source asset when no backend preview exists #1459

Merged

xiaoxia merged 3 commits from fix/cover-extract-from-source-asset into develop

2026-08-22 23:15:34 +08:00

Author	SHA1	Message	Date
xiaoxia	93540f904c	fix(cover): address AI review - temp file cleanup + per-asset error handling CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped Details CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped Details CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped Details CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped Details CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped Details CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 47s Details CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped Details CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped Details CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped Details CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 32s Details CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m37s Details PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m46s Details CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 2m6s Details Preview Deploy / Deploy Preview Environment (pull_request) Successful in 2m13s Details CI/CD Pipeline / PR Build API Image (pull_request) Successful in 1m28s Details PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m39s Details CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m57s Details AI Code Review / AI Code Review (pull_request) Successful in 4m19s Details CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 5m42s Details CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Deploy Production (pull_request) Has been skipped Details CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped Details CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped Details CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m18s Details CI/CD Pipeline / CI Gate (pull_request) Successful in 8s Details ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 55s Details Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 1m24s Details - _persist_cover_frame: use try/finally to ensure temp file is always cleaned up - Step E2: move try/except inside loop so single asset failure doesn't block others	2026-08-22 23:06:08 +08:00
CI Bot	76df0de8a4	style: auto-format with black + isort + prettier [skip ci-format-check] CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped Details CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped Details CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped Details CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped Details CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped Details CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 49s Details CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped Details CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped Details CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m26s Details CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 32s Details CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m42s Details PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m46s Details Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m47s Details CI/CD Pipeline / PR Build API Image (pull_request) Successful in 1m43s Details AI Code Review / AI Code Review (pull_request) Failing after 2m52s Details PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m28s Details CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m43s Details CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 5m21s Details CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped Details CI/CD Pipeline / Deploy Production (pull_request) Has been skipped Details CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped Details CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped Details CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m51s Details CI/CD Pipeline / CI Gate (pull_request) Successful in 8s Details	2026-08-22 14:52:01 +00:00
CI Bot	035e589dfc	fix(cover): extract cover from source asset when no backend preview exists CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped Details CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped Details CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped Details CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped Details CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped Details CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped Details CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 40s Details CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped Details CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped Details CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped Details CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 45s Details CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m37s Details CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m47s Details PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m51s Details Preview Deploy / Deploy Preview Environment (pull_request) Successful in 2m16s Details CI/CD Pipeline / PR Build API Image (pull_request) Successful in 1m40s Details AI Code Review / AI Code Review (pull_request) Successful in 2m37s Details CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m50s Details PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m40s Details CI/CD Pipeline / Validate - Code Quality (pull_request) Has been cancelled Details CI/CD Pipeline / Integration Tests (pull_request) Has been cancelled Details CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled Details CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled Details CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled Details CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled Details CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled Details CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled Details CI/CD Pipeline / CI Gate (pull_request) Has been cancelled Details The frontend now renders preview entirely in-browser via Canvas/WebCodecs, so there is no backend GenerationTask or rendered video for the cover pipeline to read. Steps A-D all rely on backend-rendered artifacts. - Remove early 400 gate on missing rendered_storage_key for ai_frame - Add step E1: extract a frame from rendered video URL when available but cover_url was not persisted (legacy data) - Add step E2: when no backend preview exists, pick the first video asset from asset_ids and ask MediaKit to extract a frame directly - Add _persist_cover_frame helper to download MediaKit frame and re-upload to OSS covers/ path for a stable public URL - Update final 400 message to reflect the real cause - Add 2 unit tests covering source-asset extraction and non-video skip - Clean stale rendered_storage_key on test plan ec4071eb	2026-08-22 22:47:52 +08:00