fix: sourceEditPlanId 不再用模板ID冒充plan_id,改由后端兜底关联 #1475

Merged
auto-approve-bot merged 1 commits from fix/source-edit-plan-id-fallback into develop 2026-08-24 10:24:54 +08:00
Owner

问题

PR #1473sourceEditPlanId 回退到 selectedTemplate(模板ID),但模板ID不是 edit_plan_id,传给Worker会导致"剪辑计划不存在"错误。

修复

  1. useGenerateFormState: sourceEditPlanId = editPlanId || null,移除 || selectedTemplate 回退
  2. useStep6Cover: createPreview 不再传 source_edit_plan_id: selectedTemplate,后端通过 template_id+user_id 兜底查找正确的 plan

设计意图

  • URL有 edit_plan_id(从剪辑模板编辑器跳转)→ 直接使用
  • URL没有 → 传 null/不传,后端正式生成API和预览API均通过 template_id+user_id 自动关联正确的 edit_plan
  • selectedTemplate 是模板ID,不能混淆为 edit_plan_id

验证

  • TSC
  • ESLint
  • Prettier
## 问题 PR #1473 中 `sourceEditPlanId` 回退到 `selectedTemplate`(模板ID),但模板ID不是 edit_plan_id,传给Worker会导致"剪辑计划不存在"错误。 ## 修复 1. **useGenerateFormState**: `sourceEditPlanId = editPlanId || null`,移除 `|| selectedTemplate` 回退 2. **useStep6Cover**: `createPreview` 不再传 `source_edit_plan_id: selectedTemplate`,后端通过 `template_id+user_id` 兜底查找正确的 plan ## 设计意图 - URL有 `edit_plan_id`(从剪辑模板编辑器跳转)→ 直接使用 - URL没有 → 传 null/不传,后端正式生成API和预览API均通过 `template_id+user_id` 自动关联正确的 edit_plan - `selectedTemplate` 是模板ID,不能混淆为 edit_plan_id ## 验证 - TSC ✅ - ESLint ✅ - Prettier ✅
xiaoxia added 1 commit 2026-08-24 10:11:13 +08:00
fix: sourceEditPlanId 不再用模板ID冒充plan_id,改由后端兜底关联
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 39s
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
AI Code Review / AI Code Review (pull_request) Successful in 1m31s
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m38s
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m48s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m11s
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m57s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 2m38s
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 2m20s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m6s
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m42s
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m34s
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
CI/CD Pipeline / CI Gate (pull_request) Successful in 16s
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 59s
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 1m1s
8641c0431a
- useGenerateFormState: sourceEditPlanId = editPlanId || null
  移除 || selectedTemplate 回退,selectedTemplate 是模板ID不是edit_plan_id
- useStep6Cover: createPreview 不再传 source_edit_plan_id: selectedTemplate
  后端预览/正式生成API均通过 template_id+user_id 兜底查找正确plan
- 更新 JSDoc 和行内注释说明设计意图
Collaborator

【阻塞级判定】

  • 是否存在阻塞级问题:否
  • 阻塞级问题数量:0 个

📊 审查概览

  • 整体评价:通过
  • 建议级问题数量:0 个

🔴 阻塞级问题(必须修复)

💡 改进建议(不阻塞合并)

良好实践

  1. 逻辑修正准确:正确识别并修复了将 selectedTemplate(模板ID)误作为 source_edit_plan_id(编辑计划ID)传递的逻辑错误,避免了因ID类型混淆导致的数据关联错误。
  2. 注释清晰详尽:在 useGenerateFormState/index.ts 中补充了详细的注释,解释了参数变更的原因及后端兜底逻辑,极大地提升了代码的可维护性。
  3. 修改范围一致:同时修正了状态管理逻辑和API调用参数,确保了前后端交互数据的一致性。

🤖 由 AI 代码审查机器人自动生成 | 2026-08-24 02:12:42 | 模型:

### 【阻塞级判定】 - 是否存在阻塞级问题:否 - 阻塞级问题数量:0 个 ### 📊 审查概览 - 整体评价:通过 - 建议级问题数量:0 个 ### 🔴 阻塞级问题(必须修复) 无 ### 💡 改进建议(不阻塞合并) 无 ### ✅ 良好实践 1. **逻辑修正准确**:正确识别并修复了将 `selectedTemplate`(模板ID)误作为 `source_edit_plan_id`(编辑计划ID)传递的逻辑错误,避免了因ID类型混淆导致的数据关联错误。 2. **注释清晰详尽**:在 `useGenerateFormState/index.ts` 中补充了详细的注释,解释了参数变更的原因及后端兜底逻辑,极大地提升了代码的可维护性。 3. **修改范围一致**:同时修正了状态管理逻辑和API调用参数,确保了前后端交互数据的一致性。 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-08-24 02:12:42 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->

🚀 预览环境已部署

项目 详情
PR号 #1475
预览链接 https://pr-1475.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后,预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1475 | | 预览链接 | [https://pr-1475.preview.xiaoxiajianji.com](https://pr-1475.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后,预览环境会自动清理。
auto-approve-bot approved these changes 2026-08-24 10:14:20 +08:00
auto-approve-bot left a comment
Collaborator

CI全绿,自动审批通过。

CI全绿,自动审批通过。
auto-approve-bot approved these changes 2026-08-24 10:14:20 +08:00
auto-approve-bot left a comment
Collaborator

CI全绿,自动审批通过。

CI全绿,自动审批通过。
auto-approve-bot merged commit 9da2fae3dd into develop 2026-08-24 10:24:54 +08:00
auto-approve-bot deleted branch fix/source-edit-plan-id-fallback 2026-08-24 10:24:55 +08:00

🗑️ 预览环境已清理

PR #1475 已关闭或合并,对应的预览环境已被清理。

如有需要,可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1475 已关闭或合并,对应的预览环境已被清理。 > 如有需要,可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.