feat: 素材选取路径接入 smart_match 评分,让用过降权真正生效 #1615

Merged
xiaoxia merged 2 commits from feat/smart-match-integration into develop 2026-09-01 20:37:26 +08:00
Owner

改动内容

路径1: from-assets (clips.py)

  • 获取素材时长的同时计算 smart_match 综合评分
  • sorted_candidates 排序键改为 (-smart_score, use_count, random)
  • 优先选评分高的素材,同分按使用次数少的优先
  • 保持现有去重机制(asset_segment_tracker、15%双闸门)不变

路径2: 一键生成 (plan_generator_service.py)

  • _distribute_assets 在非随机模式下先按 smart_match 评分排序素材
  • 新增 _sort_assets_by_smart_score 方法
  • random_selection 模式不受影响
  • 4 种 editing_mode 分配策略保持不变

测试

  • 新增 10 个测试覆盖 unused 维度降权、排序正确性、两条路径集成
  • 修复已有测试 mock 属性以兼容 score_asset
  • ruff check 通过
  • 14009 passed(10 个新增 + 原有全部通过)
  • 10 个失败均为预存在的环境兼容问题(h2 模块版本冲突等),与本次改动无关
## 改动内容 ### 路径1: from-assets (clips.py) - 获取素材时长的同时计算 smart_match 综合评分 - `sorted_candidates` 排序键改为 `(-smart_score, use_count, random)` - 优先选评分高的素材,同分按使用次数少的优先 - 保持现有去重机制(asset_segment_tracker、15%双闸门)不变 ### 路径2: 一键生成 (plan_generator_service.py) - `_distribute_assets` 在非随机模式下先按 smart_match 评分排序素材 - 新增 `_sort_assets_by_smart_score` 方法 - `random_selection` 模式不受影响 - 4 种 editing_mode 分配策略保持不变 ### 测试 - 新增 10 个测试覆盖 unused 维度降权、排序正确性、两条路径集成 - 修复已有测试 mock 属性以兼容 score_asset - ruff check 通过 - 14009 passed(10 个新增 + 原有全部通过) - 10 个失败均为预存在的环境兼容问题(h2 模块版本冲突等),与本次改动无关
xiaoxia added 1 commit 2026-09-01 19:59:18 +08:00
feat: 素材选取路径接入 smart_match 评分,让"用过降权"真正生效
CI/CD Pipeline / Check push changed paths (pull_request) Has been skipped
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 0s
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 1s
CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m40s
CI/CD Pipeline / Integration Tests (pull_request) Successful in 4m20s
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 4m52s
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Has been skipped
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 5m52s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 6m16s
CI/CD Pipeline / Validate - Style (pull_request) Has been cancelled
CI/CD Pipeline / Validate - Security (pull_request) Has been cancelled
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Has been cancelled
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been cancelled
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been cancelled
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been cancelled
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been cancelled
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
CI/CD Pipeline / CI Gate (pull_request) Has been cancelled
AI Code Review / AI Code Review (pull_request) Has been cancelled
PR Automation / Auto Approve on CI Green (pull_request) Has been cancelled
382e7a24fc
路径1 (from-assets):
- 在获取素材时长时同时计算 smart_match 评分
- sorted_candidates 排序键改为: (-smart_score, use_count, random)
- 优先选评分高的素材,同分按使用次数少的优先

路径2 (一键生成):
- _distribute_assets 在非随机模式下先按 smart_match 评分排序
- 新增 _sort_assets_by_smart_score 方法
- random_selection 模式不受影响

测试:
- 新增 10 个测试覆盖 unused 维度降权、排序正确性、两条路径集成
- 修复已有测试 mock 属性以兼容 score_asset
- ruff check 通过

🚀 预览环境已部署

项目 详情
PR号 #1615
预览链接 https://pr-1615.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后,预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1615 | | 预览链接 | [https://pr-1615.preview.xiaoxiajianji.com](https://pr-1615.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后,预览环境会自动清理。
auto-approve-bot added 1 commit 2026-09-01 20:06:50 +08:00
style: auto-format with black + isort + prettier [skip ci-format-check]
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 3s
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 1s
CI/CD Pipeline / Check push changed paths (pull_request) Has been skipped
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 2m40s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 4m21s
AI Code Review / AI Code Review (pull_request) Successful in 6m23s
CI/CD Pipeline / Frontend Lint (pull_request) Has been skipped
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
CI/CD Pipeline / PR Build Web Image (pull_request) Has been skipped
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 6m26s
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Validate - Style (pull_request) Successful in 2m9s
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m16s
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 2m40s
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m23s
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 6m28s
CI/CD Pipeline / Unit Tests (pull_request) Successful in 7m48s
CI/CD Pipeline / Validate - Security (pull_request) Successful in 22m51s
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / CI Gate (pull_request) Successful in 5s
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
ACR Cleanup / ACR Image Cleanup (pull_request_target) Waiting to run
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 4m46s
f1a19acc61
Collaborator

代码审查结果 - PR #1615

⚠️ 问题(0个需要修改)

(无)

💡 建议(1个可选)

  1. apps/api/app/services/plan_generator_service.py 第234-247行:性能优化建议
    • 描述_sort_assets_by_smart_score 方法中循环调用 self._asset_repo.get(asset_id) 获取素材详情。而在调用 _distribute_assets 之前,通常已经调用过 _fetch_asset_durations(或其他逻辑)获取过素材信息。这会导致重复的数据库查询或缓存调用。
    • 建议:考虑将已获取的 asset 对象或必要的评分上下文(如 duration, metadata)传递给排序方法,或者重构逻辑以复用已加载的数据,避免 N+1 查询问题。

格式检查通过 | 逻辑审查通过 | ⚠️ 建议关注性能


🤖 由 AI 代码审查机器人自动生成 | 2026-09-01 12:16:39 | 模型:

## 代码审查结果 - PR #1615 ### ⚠️ 问题(0个需要修改) (无) ### 💡 建议(1个可选) 1. **apps/api/app/services/plan_generator_service.py 第234-247行**:性能优化建议 - **描述**:`_sort_assets_by_smart_score` 方法中循环调用 `self._asset_repo.get(asset_id)` 获取素材详情。而在调用 `_distribute_assets` 之前,通常已经调用过 `_fetch_asset_durations`(或其他逻辑)获取过素材信息。这会导致重复的数据库查询或缓存调用。 - **建议**:考虑将已获取的 asset 对象或必要的评分上下文(如 duration, metadata)传递给排序方法,或者重构逻辑以复用已加载的数据,避免 N+1 查询问题。 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ⚠️ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-09-01 12:16:39 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia merged commit 9d5ae7a5bc into develop 2026-09-01 20:37:26 +08:00

🗑️ 预览环境已清理

PR #1615 已关闭或合并,对应的预览环境已被清理。

如有需要,可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1615 已关闭或合并,对应的预览环境已被清理。 > 如有需要,可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.