fix: #1789 标题字号滑块拖动回弹 — useMemo 稳定引用 + ref 防御 #1793

Merged
xiaoxia merged 1 commits from fix/1789-title-slider-bounce into develop 2026-09-08 13:28:51 +08:00
Owner

问题

拖动标题字号滑块时,值被自动回弹到模板默认值(如 28px),无法停留在用户选择的位置。

根因

useTitleCoverSync 的 useEffect 依赖了 userTemplates(每次渲染 .filter() 生成新数组引用),导致:

用户拖滑块 → setState → 组件重渲染 → allTemplates.filter() 新引用 →
useTitleCoverSync effect 触发 → 从模板 title_config.font_size 覆盖 → slider 回弹

修复

修复1(核心)— useTemplateSelection.ts

useMemo 缓存 validTemplates,仅在 allTemplates 变化时重新计算,稳定下游引用:

const validTemplates = useMemo(() => allTemplates.filter(isValidTemplate), [allTemplates])

修复2(防御性)— useTitleCoverSync.ts

useRef 持有最新 userTemplates,从 effect 依赖数组移除,effect 只在 selectedTemplate 真正变化时触发:

const templatesRef = useRef(userTemplates)
templatesRef.current = userTemplates

useEffect(() => {
  const tpl = templatesRef.current.find((t) => t.id === selectedTemplate)
  // ...
}, [selectedTemplate, setTitleSettings, setCoverSettings])
// ↑ 移除 userTemplates

验收标准

  • 拖动字号滑块从 12→128,slider 值不回弹,预览标题大小实时变化
  • 切换模板时,标题样式仍能从模板 title_config 正确同步(不回归)
  • 样式按钮(粗体/斜体/描边/阴影)切换即时生效
  • CI 全绿
## 问题 拖动标题字号滑块时,值被自动回弹到模板默认值(如 28px),无法停留在用户选择的位置。 ## 根因 `useTitleCoverSync` 的 useEffect 依赖了 `userTemplates`(每次渲染 `.filter()` 生成新数组引用),导致: ``` 用户拖滑块 → setState → 组件重渲染 → allTemplates.filter() 新引用 → useTitleCoverSync effect 触发 → 从模板 title_config.font_size 覆盖 → slider 回弹 ``` ## 修复 ### 修复1(核心)— `useTemplateSelection.ts` 用 `useMemo` 缓存 `validTemplates`,仅在 `allTemplates` 变化时重新计算,稳定下游引用: ```ts const validTemplates = useMemo(() => allTemplates.filter(isValidTemplate), [allTemplates]) ``` ### 修复2(防御性)— `useTitleCoverSync.ts` 用 `useRef` 持有最新 `userTemplates`,从 effect 依赖数组移除,effect 只在 `selectedTemplate` 真正变化时触发: ```ts const templatesRef = useRef(userTemplates) templatesRef.current = userTemplates useEffect(() => { const tpl = templatesRef.current.find((t) => t.id === selectedTemplate) // ... }, [selectedTemplate, setTitleSettings, setCoverSettings]) // ↑ 移除 userTemplates ``` ## 验收标准 - [ ] 拖动字号滑块从 12→128,slider 值不回弹,预览标题大小实时变化 - [ ] 切换模板时,标题样式仍能从模板 title_config 正确同步(不回归) - [ ] 样式按钮(粗体/斜体/描边/阴影)切换即时生效 - [ ] CI 全绿
xiaoxia added 1 commit 2026-09-08 13:23:38 +08:00
fix: #1789 标题字号滑块拖动回弹 — useMemo 稳定引用 + ref 防御
CI/CD Pipeline / Check push changed paths (pull_request) Has been skipped
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 2s
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 1s
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / PR Build API Image (pull_request) Has been skipped
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / Validate - Style (pull_request) Successful in 1m7s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 1m37s
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m46s
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m51s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m56s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m56s
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 1m57s
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 5s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 3m16s
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 22s
CI/CD Pipeline / Validate - Security (pull_request) Successful in 5m50s
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
CI/CD Pipeline / CI Gate (pull_request) Successful in 9s
AI Code Review / AI Code Review (pull_request) Successful in 6m16s
c61bead0e0
根因:useTitleCoverSync 的 useEffect 依赖 userTemplates(每次渲染
.filter() 生成新数组引用),导致:
  用户拖滑块 → setState → 重渲染 → 新数组引用 → effect 触发 →
  从模板 title_config.font_size 覆盖回去 → slider 回弹

修复1(核心):useTemplateSelection.ts 用 useMemo 缓存 validTemplates,
  仅在 allTemplates 变化时重新计算,稳定下游引用。
修复2(防御性):useTitleCoverSync.ts 用 ref 持有 userTemplates,
  从依赖数组移除,effect 只在 selectedTemplate 真正变化时触发。

🚀 预览环境已部署

项目 详情
PR号 #1793
预览链接 https://pr-1793.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后,预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1793 | | 预览链接 | [https://pr-1793.preview.xiaoxiajianji.com](https://pr-1793.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后,预览环境会自动清理。
auto-approve-bot approved these changes 2026-09-08 13:25:34 +08:00
auto-approve-bot left a comment
Collaborator

CI全绿,自动审批通过。

CI全绿,自动审批通过。
auto-approve-bot approved these changes 2026-09-08 13:25:34 +08:00
auto-approve-bot left a comment
Collaborator

CI全绿,自动审批通过。

CI全绿,自动审批通过。
xiaoxia merged commit 6904fce511 into develop 2026-09-08 13:28:51 +08:00

🗑️ 预览环境已清理

PR #1793 已关闭或合并,对应的预览环境已被清理。

如有需要,可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1793 已关闭或合并,对应的预览环境已被清理。 > 如有需要,可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.