xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 16 Pull Requests 8 Actions 34.2k Packages Projects Releases 7 Wiki Activity

fix(lipsync): 修复 lipsync_tts 跨容器 import 错误导致 API/Worker 启动崩溃 #1849

Closed
xiaoxia wants to merge 1 commits from fix/lipsync-tts-deploy-crash into develop
pull from: fix/lipsync-tts-deploy-crash
merge into: xiaoxia:develop
Conversation 3 Commits 1 Files Changed 2
+58 -9
xiaoxia commented 2026-09-10 20:51:05 +08:00
Owner
Copy Link
Copy Source

问题

PR #1844 合并后 staging 部署失败（已自动回滚）。API 容器启动时 import lipsync_service → lipsync_tts 报错：

File "/app/apps/api/app/tasks/lipsync_tts.py", line 18
  from apps.worker.worker_app.celery_app import celery_app
ModuleNotFoundError: No module named 'apps.worker'

API 镜像不包含 apps/worker/ 目录（worker 是独立容器），从 worker 路径导入 celery_app 必然失败，健康检查 120s 超时触发自动回滚。

修复

  1. celery_app 导入路径：apps.worker.worker_app.celery_app → app.core.celery_app（API 侧 Celery app，API/Worker 镜像都复制了 core/）
  2. 去掉对 LipsyncService 反射依赖：LipsyncService.__new__ 调用 _sign_media_url 的 hacky 方式改为模块内独立 _sign_media_url() 函数（Worker 镜像不复制 services 目录，反射导入同样会崩）
  3. Worker 镜像补文件：worker.Dockerfile 补充 apps/api/app/tasks/、mediakit_client.py 及必需的 __init__.py，保证 Worker 能 import lipsync_tts task 并注册 Celery 路由。

测试

  • 56 个单元测试全部通过
  • 覆盖率：lipsync_tts.py 92% / lipsync_service.py 67% / 合计 76%
  • ruff/black/isort 均通过
## 问题 PR #1844 合并后 staging 部署失败（已自动回滚）。API 容器启动时 import lipsync_service → lipsync_tts 报错： ``` File "/app/apps/api/app/tasks/lipsync_tts.py", line 18 from apps.worker.worker_app.celery_app import celery_app ModuleNotFoundError: No module named 'apps.worker' ``` API 镜像不包含 `apps/worker/` 目录（worker 是独立容器），从 worker 路径导入 celery_app 必然失败，健康检查 120s 超时触发自动回滚。 ## 修复 1. **celery_app 导入路径**：`apps.worker.worker_app.celery_app` → `app.core.celery_app`（API 侧 Celery app，API/Worker 镜像都复制了 core/） 2. **去掉对 LipsyncService 反射依赖**：`LipsyncService.__new__` 调用 `_sign_media_url` 的 hacky 方式改为模块内独立 `_sign_media_url()` 函数（Worker 镜像不复制 services 目录，反射导入同样会崩） 3. **Worker 镜像补文件**：worker.Dockerfile 补充 `apps/api/app/tasks/`、`mediakit_client.py` 及必需的 `__init__.py`，保证 Worker 能 import lipsync_tts task 并注册 Celery 路由。 ## 测试 - 56 个单元测试全部通过 - 覆盖率：lipsync_tts.py 92% / lipsync_service.py 67% / 合计 76% - ruff/black/isort 均通过
xiaoxia added 1 commit 2026-09-10 20:51:05 +08:00
fix(lipsync): 修复 lipsync_tts 跨容器 import 错误导致 API/Worker 启动崩溃
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 2s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 3s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m5s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 29s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 15s
Details
CI/CD Pipeline / Validate - Style (pull_request) Successful in 2m40s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 3m2s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m21s
Details
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 4m29s
Details
AI Code Review / AI Code Review (pull_request) Successful in 6m40s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 8m40s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 10m55s
Details
CI/CD Pipeline / Validate - Security (pull_request) Successful in 25m25s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 1s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 16s
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Failing after 138h7m12s
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 138h30m19s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 138h31m0s
Details
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Failing after 138h32m37s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 138h30m17s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 138h30m14s
Details
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Failing after 138h32m23s
Details
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Failing after 138h32m24s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 138h32m32s
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 138h32m32s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 138h32m32s
Details
CI/CD Pipeline / Check push changed paths (pull_request) Failing after 138h32m33s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Failing after 138h6m59s
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Failing after 138h6m58s
Details
CI/CD Pipeline / Deploy Production (pull_request) Failing after 138h6m58s
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Failing after 138h6m59s
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Failing after 138h30m9s
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 138h30m6s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 138h30m52s
Details
72d8e99991 
lipsync_tts.py 原从 apps.worker.worker_app 导入 celery_app，而 API 镜像中没有 apps.worker 目录，
导致 API 容器导入 lipsync_service 时 ModuleNotFoundError，健康检查失败触发自动回滚。

修复：
1. celery_app 改为从 app.core.celery_app 导入（API 侧 Celery app，API/Worker 镜像均存在）
2. _sign_media_url 改为模块内独立函数，去掉对 LipsyncService.__new__ 反射调用的依赖
   （Worker 镜像不复制 services 目录，反射导入会失败）
3. worker.Dockerfile 补充 apps/api/app/tasks/、mediakit_client.py 及必需的 __init__.py
   （Worker 进程需能 import lipsync_tts task 并注册 Celery 路由）
gitea-actions bot commented 2026-09-10 20:54:08 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1849
预览链接 https://pr-1849.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1849 | | 预览链接 | [https://pr-1849.preview.xiaoxiajianji.com](https://pr-1849.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia closed this pull request 2026-09-15 07:09:36 +08:00
gitea-actions bot commented 2026-09-15 07:09:53 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1849 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1849 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
xiaoxia commented 2026-09-15 07:43:33 +08:00
Author
Owner
Copy Link
Copy Source

PR#1867 已合入 lipsync 三层防御（包含本 PR 的 celery_app 路径修复 + worker.Dockerfile COPY apps/api/app/ + @shared_task 改造），CI 全绿并部署 staging，本 PR 已被覆盖，关闭。

PR#1867 已合入 lipsync 三层防御（包含本 PR 的 celery_app 路径修复 + worker.Dockerfile COPY apps/api/app/ + @shared_task 改造），CI 全绿并部署 staging，本 PR 已被覆盖，关闭。
Some checks are pending
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 2s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 3s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m5s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 29s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 15s
Details
CI/CD Pipeline / Validate - Style (pull_request) Successful in 2m40s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 3m2s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m21s
Details
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 4m29s
Details
AI Code Review / AI Code Review (pull_request) Successful in 6m40s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 8m40s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 10m55s
Details
CI/CD Pipeline / Validate - Security (pull_request) Successful in 25m25s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Successful in 1s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 16s
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Failing after 138h7m12s
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 138h30m19s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 138h31m0s
Details
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Failing after 138h32m37s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 138h30m17s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 138h30m14s
Details
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Failing after 138h32m23s
Details
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Failing after 138h32m24s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 138h32m32s
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 138h32m32s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 138h32m32s
Details
CI/CD Pipeline / Check push changed paths (pull_request) Failing after 138h32m33s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Failing after 138h6m59s
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Failing after 138h6m58s
Details
CI/CD Pipeline / Deploy Production (pull_request) Failing after 138h6m58s
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Failing after 138h6m59s
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Failing after 138h30m9s
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 138h30m6s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 138h30m52s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot frontend-dev xiaoxia
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1849
Delete Branch "fix/lipsync-tts-deploy-crash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?