fix(code-quality): 第一批代码质量修复 - 零风险项 #336

2026-07-15T00:52:05+08:00

xiaoxia commented

2026-07-15 00:52:05 +08:00

变更内容

第一批代码质量修复（零风险项），全部为机械修复不涉及业务逻辑变更。

1. 修复 ruff 配置兼容性

移除 W503 / E704 规则（ruff 0.14+ 已移除，导致 CI 中 ruff 启动失败）
此前 ruff 在 CI 中实际未运行，被告警模式掩盖

2. F541 f-string 无占位符（13处）

scripts/check_migration_safety.py
scripts/ci_notify.py
scripts/init_phase6_tasks.py
scripts/init_tracker_data.py
全部通过 ruff --fix 自动修复

3. B017 assert raises Exception（1处）

tests/unit/test_config_schemas_and_ai_endpoints.py
pytest.raises(Exception) 改为 pytest.raises(ValidationError)

4. vulture 死代码（1处）

apps/worker/video_processing/trim_engine.py
删除 if False 的三元表达式死代码

5. mypy var-annotated（1处）

apps/api/app/middleware/versioning.py
SUNSET_VERSIONS 补充 list[str] 类型标注

验证

✅ ruff 全量扫描：F541/B017 清零
✅ black --check 格式通过
✅ test_bgm_config_validation 单测通过

## 变更内容第一批代码质量修复（零风险项），全部为机械修复不涉及业务逻辑变更。 ### 1. 修复 ruff 配置兼容性 - 移除 `W503` / `E704` 规则（ruff 0.14+ 已移除，导致 CI 中 ruff 启动失败） - 此前 ruff 在 CI 中实际未运行，被告警模式掩盖 ### 2. F541 f-string 无占位符（13处） - `scripts/check_migration_safety.py` - `scripts/ci_notify.py` - `scripts/init_phase6_tasks.py` - `scripts/init_tracker_data.py` - 全部通过 `ruff --fix` 自动修复 ### 3. B017 assert raises Exception（1处） - `tests/unit/test_config_schemas_and_ai_endpoints.py` - `pytest.raises(Exception)` 改为 `pytest.raises(ValidationError)` ### 4. vulture 死代码（1处） - `apps/worker/video_processing/trim_engine.py` - 删除 `if False` 的三元表达式死代码 ### 5. mypy var-annotated（1处） - `apps/api/app/middleware/versioning.py` - `SUNSET_VERSIONS` 补充 `list[str]` 类型标注 ## 验证 - ✅ ruff 全量扫描：F541/B017 清零 - ✅ black --check 格式通过 - ✅ test_bgm_config_validation 单测通过

xiaoxia added 1 commit 2026-07-15 00:52:05 +08:00

fix(code-quality): 第一批代码质量修复 - 零风险项

CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 2m30s

Details

CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m44s

Details

CI/CD Pipeline / Frontend Lint (pull_request) Successful in 3m5s

Details

CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped

Details

CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped

Details

CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped

Details

CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped

Details

CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped

Details

CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped

Details

CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped

Details

CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped

Details

CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped

Details

CI/CD Pipeline / Deploy Production (pull_request) Has been skipped

Details

CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped

Details

CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m28s

Details

6cbd08f666

- 修复 ruff 配置：移除已废弃规则 W503/E704（ruff 0.14+ 不兼容）
- 修复 F541 (13处)：f-string 无占位符改为普通字符串
- 修复 B017 (1处)：pytest.raises(Exception) 改为 ValidationError
- 修复 vulture 死代码：trim_engine 中 if False 的三元表达式
- 修复 mypy var-annotated：SUNSET_VERSIONS 加类型标注

xiaoxia merged commit 9e9725015e into develop

2026-07-15 07:38:54 +08:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#336