xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 3 Actions 1 Packages Projects Releases 7 Wiki Activity

fix(ci): 修复auto-approve审批状态为PENDING的问题 #461

Merged
auto-approve-bot merged 1 commits from fix/auto-approve-review-submit into develop 2026-07-17 12:18:22 +08:00
Conversation 2 Commits 1 Files Changed 1
+38 -12
xiaoxia commented 2026-07-17 12:14:20 +08:00
Owner
Copy Link
Copy Source

问题

Gitea的CreatePullReview API创建的review默认是PENDING状态，即使传了event=APPROVE也不会自动提交，需要额外调用submit API。

导致auto-approve的workflow run显示success，但PR的review实际是PENDING状态，不满足合并条件。

修复

改为两步操作：

  1. POST /reviews 创建PENDING状态的review
  2. POST /reviews/{id} 提交为APPROVED状态

验证

本PR是CI相关改动，将触发auto-approve，修复生效后应能自动打审批，然后配合auto-merge自动合并。

## 问题 Gitea的CreatePullReview API创建的review默认是PENDING状态，即使传了`event=APPROVE`也不会自动提交，需要额外调用submit API。 导致auto-approve的workflow run显示success，但PR的review实际是PENDING状态，不满足合并条件。 ## 修复 改为两步操作： 1. `POST /reviews` 创建PENDING状态的review 2. `POST /reviews/{id}` 提交为APPROVED状态 ## 验证 本PR是CI相关改动，将触发auto-approve，修复生效后应能自动打审批，然后配合auto-merge自动合并。
xiaoxia added 1 commit 2026-07-17 12:14:20 +08:00
fix(ci): auto-approve review需两步提交 - Gitea API要先创建PENDING再submit为APPROVED
CI Build & Deploy Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 10s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 43s
Details
AI Code Review / AI Code Review (pull_request) Successful in 58s
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 1m45s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m35s
Details
Auto Approve CI PRs / Auto Approve on CI Green (pull_request) Successful in 2m55s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m18s
Details
Auto Merge CI PRs / Auto Merge on CI Green + Approved (pull_request) Successful in 4m1s
Details
1b52b76bdb
auto-approve-bot approved these changes 2026-07-17 12:17:16 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-17 12:17:16 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot merged commit 492a84afe2 into develop 2026-07-17 12:18:22 +08:00
auto-approve-bot deleted branch fix/auto-approve-review-submit 2026-07-17 12:18:22 +08:00
xiaoxia added the ci-bug label 2026-07-17 12:24:07 +08:00
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label ci-bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#461
Delete Branch "fix/auto-approve-review-submit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?