xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix(P0): 修复视频标题不生效 + 成片库名称硬编码 #553

Merged
auto-approve-bot merged 1 commits from fix/p0-title-not-working into develop 2026-07-19 01:01:28 +08:00
Conversation 3 Commits 1 Files Changed 3
+121 -2
xiaoxia commented 2026-07-19 00:55:45 +08:00
Owner
Copy Link
Copy Source

修复内容

根因

  1. legacy引擎完全没有标题/字幕叠加：默认渲染引擎是legacy，_render_with_legacy 只做画面拼接，完全没有处理 plan.config.title 和 plan.config.subtitle，导致用户设置的标题在视频中不显示
  2. 成片库视频名称硬编码：create_video_record_and_dedup 中 name 写死为 generated-{task_id}.mp4，没有使用用户设置的标题

修复方案

  1. legacy路径加标题/字幕叠加：FFmpeg渲染完成后、上传OSS前，检查title/subtitle配置，生成ASS字幕文件并用subtitles滤镜叠加。失败降级不阻断主流程
  2. 成片库名称使用标题：create_video_record_and_dedup 新增name参数，_finalize_render_success 从 plan.config.title.text 读取，空则fallback到默认命名

改动文件

  • apps/worker/worker_app/tasks/edit_plan_generation.py — legacy标题字幕叠加 + name透传
  • apps/worker/video_processing/dedup_helpers.py — 支持自定义name参数
  • tests/unit/test_generated_video_creation_logic.py — 新增3个测试
## 修复内容 ### 根因 1. **legacy引擎完全没有标题/字幕叠加**：默认渲染引擎是legacy，`_render_with_legacy` 只做画面拼接，完全没有处理 `plan.config.title` 和 `plan.config.subtitle`，导致用户设置的标题在视频中不显示 2. **成片库视频名称硬编码**：`create_video_record_and_dedup` 中 name 写死为 `generated-{task_id}.mp4`，没有使用用户设置的标题 ### 修复方案 1. **legacy路径加标题/字幕叠加**：FFmpeg渲染完成后、上传OSS前，检查title/subtitle配置，生成ASS字幕文件并用subtitles滤镜叠加。失败降级不阻断主流程 2. **成片库名称使用标题**：`create_video_record_and_dedup` 新增name参数，`_finalize_render_success` 从 `plan.config.title.text` 读取，空则fallback到默认命名 ### 改动文件 - `apps/worker/worker_app/tasks/edit_plan_generation.py` — legacy标题字幕叠加 + name透传 - `apps/worker/video_processing/dedup_helpers.py` — 支持自定义name参数 - `tests/unit/test_generated_video_creation_logic.py` — 新增3个测试
xiaoxia added the bugbackendP0 labels 2026-07-19 00:55:45 +08:00
xiaoxia added 1 commit 2026-07-19 00:55:45 +08:00
fix(P0): 修复视频标题不生效 + 成片库名称硬编码
CI Build & Deploy Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 14s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 15s
Details
AI Code Review / AI Code Review (pull_request) Failing after 32s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 33s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 49s
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 2m30s
Details
Auto Approve CI PRs / Auto Approve on CI Green (pull_request) Successful in 2m55s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m56s
Details
Auto Merge CI PRs / Auto Merge on CI Green + Approved (pull_request) Successful in 5m42s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 34s
Details
a540da09bb 
- legacy引擎路径新增标题/字幕叠加（渲染完成后用ASS字幕滤镜叠加）
- create_video_record_and_dedup 支持传入自定义name参数
- _finalize_render_success 从plan.config.title.text读取视频名称
- 失败降级不阻断主流程
- 新增3个单元测试验证名称逻辑
auto-approve-bot approved these changes 2026-07-19 00:58:40 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-19 00:58:41 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot merged commit 6418924842 into develop 2026-07-19 01:01:28 +08:00
auto-approve-bot deleted branch fix/p0-title-not-working 2026-07-19 01:01:28 +08:00
gitea-actions bot commented 2026-07-19 01:02:02 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #553 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #553 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label P0 backend bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#553
Delete Branch "fix/p0-title-not-working"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?