xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 9 Pull Requests 3 Actions Packages Projects Releases 7 Wiki Activity

fix: 修复ingest测试MagicMock写入SQLite导致Unit Tests失败 #601

Merged
auto-approve-bot merged 1 commits from fix/ingest-thumbnail-type into develop 2026-07-19 17:40:44 +08:00
Conversation 3 Commits 1 Files Changed 2
+4 -3
xiaoxia commented 2026-07-19 17:32:36 +08:00
Owner
Copy Link
Copy Source

问题

CI Unit Tests失败：test_valid_video_marked_as_ready 报 sqlite3.InterfaceError: Error binding parameter 8

根因：CI环境中 video_processing.thumbnail_generator 被全局mock成MagicMock模块，generate_and_upload_thumbnail() 返回MagicMock对象而非None，导致thumbnail_url是MagicMock类型，写入SQLite时报错。

修复

  1. Asset.create中增加类型清洗：thumbnail_url确保是str或None
  2. 测试中显式mock generate_and_upload_thumbnail返回None

影响

修复develop分支Unit Tests门禁失败问题

## 问题 CI Unit Tests失败：test_valid_video_marked_as_ready 报 sqlite3.InterfaceError: Error binding parameter 8 根因：CI环境中 video_processing.thumbnail_generator 被全局mock成MagicMock模块，generate_and_upload_thumbnail() 返回MagicMock对象而非None，导致thumbnail_url是MagicMock类型，写入SQLite时报错。 ## 修复 1. Asset.create中增加类型清洗：thumbnail_url确保是str或None 2. 测试中显式mock generate_and_upload_thumbnail返回None ## 影响 修复develop分支Unit Tests门禁失败问题
xiaoxia added 1 commit 2026-07-19 17:32:36 +08:00
fix: ingest测试中thumbnail_url类型错误，Asset.create增加类型清洗+补mock
CI Build & Deploy Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI Build & Deploy Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 25s
Details
AI Code Review / AI Code Review (pull_request) Failing after 29s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 35s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 1m4s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 3m11s
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 4m18s
Details
Auto Approve CI PRs / Auto Approve on CI Green (pull_request) Successful in 5m26s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m41s
Details
Auto Merge CI PRs / Auto Merge on CI Green + Approved (pull_request) Successful in 8m4s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 33s
Details
c973159e1d
auto-approve-bot approved these changes 2026-07-19 17:38:03 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-19 17:38:03 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot merged commit edb118a5a0 into develop 2026-07-19 17:40:44 +08:00
auto-approve-bot deleted branch fix/ingest-thumbnail-type 2026-07-19 17:40:44 +08:00
gitea-actions bot commented 2026-07-19 17:41:16 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #601 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #601 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#601
Delete Branch "fix/ingest-thumbnail-type"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?