xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 9 Pull Requests 3 Actions 3 Packages Projects Releases 7 Wiki Activity

test: 新增认证模块和封面服务单元测试，覆盖率提升至96%+ #654

Merged
auto-approve-bot merged 2 commits from test/unit-test-coverage-improvement into develop 2026-07-20 20:43:22 +08:00
Conversation 5 Commits 2 Files Changed 3
+1069
xiaoxia commented 2026-07-20 20:05:04 +08:00
Owner
Copy Link
Copy Source

P1-4 单元测试质量提升

新增测试文件

  • tests/unit/test_login_use_case.py - 23个用例
  • tests/unit/test_jwt_service.py - 24个用例
  • tests/unit/test_cover_service.py - 20个用例

覆盖率提升

模块 提升前 提升后
login_use_case ~20% 96%
jwt_service ~23% 97%
cover_service ~60% 96%

覆盖场景

认证登录模块:

  • 登录成功/失败/旧密码升级
  • Token刷新/失效/不匹配
  • 单设备/全设备登出

JWT服务:

  • Token生成与验证
  • 过期/无效/错误密钥
  • 配置安全校验

封面服务:

  • 封面配置提取
  • 抽帧成功/失败分支
  • FFmpeg回退逻辑
  • 智能封面生成
## P1-4 单元测试质量提升 ### 新增测试文件 - `tests/unit/test_login_use_case.py` - 23个用例 - `tests/unit/test_jwt_service.py` - 24个用例 - `tests/unit/test_cover_service.py` - 20个用例 ### 覆盖率提升 | 模块 | 提升前 | 提升后 | |------|--------|--------| | login_use_case | ~20% | **96%** | | jwt_service | ~23% | **97%** | | cover_service | ~60% | **96%** | ### 覆盖场景 **认证登录模块:** - 登录成功/失败/旧密码升级 - Token刷新/失效/不匹配 - 单设备/全设备登出 **JWT服务:** - Token生成与验证 - 过期/无效/错误密钥 - 配置安全校验 **封面服务:** - 封面配置提取 - 抽帧成功/失败分支 - FFmpeg回退逻辑 - 智能封面生成
xiaoxia added 1 commit 2026-07-20 20:05:04 +08:00
test: 新增认证模块和封面服务单元测试，覆盖率提升至96%+
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 8s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m50s
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Failing after 1m25s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 2m43s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 1m36s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m56s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 8m5s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 9m26s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m53s
Details
0dc65b6f41 
- 新增 login_use_case 测试：23个用例，覆盖登录/刷新/登出全流程
- 新增 jwt_service 测试：24个用例，覆盖token生成/验证/配置校验
- 新增 cover_service 测试：20个用例，覆盖配置提取/抽帧/智能封面

三个模块覆盖率从20-60%提升至96%+
gitea-actions bot commented 2026-07-20 20:08:50 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #654
预览链接 https://pr-654.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #654 | | 预览链接 | [https://pr-654.preview.xiaoxiajianji.com](https://pr-654.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia added 1 commit 2026-07-20 20:36:37 +08:00
style: black format test files
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 15s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m38s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 1m34s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m14s
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 4m57s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 5m36s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 5m43s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 6m46s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 14s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 4m31s
Details
9acee4d1ca
auto-approve-bot commented 2026-07-20 20:38:51 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #654

⚠️ 问题（0个需要修改）

无

💡 建议（1个可选）

  1. tests/unit/test_cover_service.py 第54行：测试断言不完整
    • 问题描述：在 test_get_cover_config_empty_cover_dict 测试中，仅断言了 type 和 image_url，未断言 frame_time。虽然 test_get_cover_config_default 已覆盖默认值，但为了确保空字典作为输入时行为一致（例如避免未来代码错误地将 frame_time 默认为 0 而非 None），建议补充断言 assert result["frame_time"] is None。

✅ 格式检查通过 | ✅ 逻辑审查需修改 | ✅ 建议关注性能

🤖 由 AI 代码审查机器人自动生成 | 2026-07-20 20:38:51 | 模型:

## 代码审查结果 - PR #654 ### ⚠️ 问题（0个需要修改） 无 ### 💡 建议（1个可选） 1. **tests/unit/test_cover_service.py 第54行**：测试断言不完整 - 问题描述：在 `test_get_cover_config_empty_cover_dict` 测试中，仅断言了 `type` 和 `image_url`，未断言 `frame_time`。虽然 `test_get_cover_config_default` 已覆盖默认值，但为了确保空字典作为输入时行为一致（例如避免未来代码错误地将 `frame_time` 默认为 0 而非 None），建议补充断言 `assert result["frame_time"] is None`。 --- ✅ 格式检查通过 | ✅ 逻辑审查需修改 | ✅ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-20 20:38:51 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
auto-approve-bot approved these changes 2026-07-20 20:42:20 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-20 20:42:20 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot merged commit 7260ee282f into develop 2026-07-20 20:43:22 +08:00
auto-approve-bot deleted branch test/unit-test-coverage-improvement 2026-07-20 20:43:22 +08:00
gitea-actions bot commented 2026-07-20 20:43:35 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #654 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #654 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#654
Delete Branch "test/unit-test-coverage-improvement"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?