xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 9 Pull Requests 2 Actions 1 Packages Projects Releases 7 Wiki Activity

perf(ci): P2-5 Frontend Lint瘦身 - 移除重复Vitest，节省4-5min #655

Merged
auto-approve-bot merged 1 commits from p2-5-frontend-lint-slim into develop 2026-07-20 21:05:18 +08:00
Conversation 5 Commits 1 Files Changed 1
-3
xiaoxia commented 2026-07-20 20:59:35 +08:00
Owner
Copy Link
Copy Source

优化内容

Frontend Lint 去掉重复的 Vitest 执行

  • Frontend Lint 中原来跑了 vitest run src/test（约4-5分钟）
  • Frontend Unit Tests job 又跑了一遍 vitest run --coverage（同样的测试+覆盖率）
  • 两边跑完全一样的测试，纯浪费

Frontend Lint 现在只做：

  • ESLint 代码风格检查
  • TypeScript 类型检查 (tsc --noEmit)
  • Prettier 格式检查

Vitest 统一由 Frontend Unit Tests 负责：

  • 带覆盖率报告
  • 本来就是专门跑单测的 job

预期收益

  • Frontend Lint 耗时：6m49s → ~2min（节省约5min）
  • PR场景CI总耗时：8-10min → 3-5min（缩短约50%）

风险

  • 无：Vitest本来就在Frontend Unit Tests里跑，只是去掉重复执行而已
## 优化内容 **Frontend Lint 去掉重复的 Vitest 执行** - Frontend Lint 中原来跑了 `vitest run src/test`（约4-5分钟） - Frontend Unit Tests job 又跑了一遍 `vitest run --coverage`（同样的测试+覆盖率） - 两边跑完全一样的测试，纯浪费 **Frontend Lint 现在只做：** - ESLint 代码风格检查 - TypeScript 类型检查 (tsc --noEmit) - Prettier 格式检查 **Vitest 统一由 Frontend Unit Tests 负责：** - 带覆盖率报告 - 本来就是专门跑单测的 job ## 预期收益 - Frontend Lint 耗时：6m49s → ~2min（节省约5min） - PR场景CI总耗时：8-10min → 3-5min（缩短约50%） ## 风险 - 无：Vitest本来就在Frontend Unit Tests里跑，只是去掉重复执行而已
xiaoxia added 1 commit 2026-07-20 20:59:35 +08:00
perf(ci): Frontend Lint移除Vitest，避免与Frontend Unit Tests重复执行
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 11s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m39s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 2m0s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m7s
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 4m21s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 4m38s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 5m40s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 18s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 7m35s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 4m32s
Details
05c987f49f 
Frontend Lint只保留ESLint/TSC/Prettier检查
Vitest由Frontend Unit Tests job专门负责（带覆盖率）
预计节省约4-5分钟/PR
gitea-actions bot commented 2026-07-20 21:01:16 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #655
预览链接 https://pr-655.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #655 | | 预览链接 | [https://pr-655.preview.xiaoxiajianji.com](https://pr-655.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-07-20 21:01:43 +08:00
Collaborator
Copy Link
Copy Source

📊 审查概览

  • 整体评价：需修改
  • 严重问题数量：1 个
  • 一般建议数量：0 个

❌ 需修改的问题（严重）

  1. [.gitea/workflows/ci-pipeline.yml: 338-340] 移除自动化测试执行步骤
    • 问题描述：代码变更直接删除了 "Run Vitest tests" 步骤，导致 CI 流水线不再自动执行前端单元测试（vitest）。
    • 后果：这将导致代码质量保障（QA）环节缺失，未经单元测试验证的代码可能被合并到主分支，显著增加回归风险和潜在的线上 Bug。
    • 修改建议：请确认移除该步骤的意图。
      • 如果测试已迁移至其他 Job 或文件，请确保新的测试流程已生效；
      • 如果是因为测试不稳定或耗时过长而临时禁用，建议保留步骤并添加条件跳过（如 if: false）并附带详细的注释说明原因，而非直接删除代码逻辑。

💡 改进建议（一般）

无

✅ 良好实践

无

🤖 由 AI 代码审查机器人自动生成 | 2026-07-20 21:01:43 | 模型:

### 📊 审查概览 - 整体评价：需修改 - 严重问题数量：1 个 - 一般建议数量：0 个 ### ❌ 需修改的问题（严重） 1. **[.gitea/workflows/ci-pipeline.yml: 338-340] 移除自动化测试执行步骤** - **问题描述**：代码变更直接删除了 "Run Vitest tests" 步骤，导致 CI 流水线不再自动执行前端单元测试（`vitest`）。 - **后果**：这将导致代码质量保障（QA）环节缺失，未经单元测试验证的代码可能被合并到主分支，显著增加回归风险和潜在的线上 Bug。 - **修改建议**：请确认移除该步骤的意图。 - 如果测试已迁移至其他 Job 或文件，请确保新的测试流程已生效； - 如果是因为测试不稳定或耗时过长而临时禁用，建议保留步骤并添加条件跳过（如 `if: false`）并附带详细的注释说明原因，而非直接删除代码逻辑。 ### 💡 改进建议（一般） 无 ### ✅ 良好实践 无 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-20 21:01:43 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
auto-approve-bot approved these changes 2026-07-20 21:04:14 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-20 21:04:14 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot merged commit 8be5df5a11 into develop 2026-07-20 21:05:18 +08:00
auto-approve-bot deleted branch p2-5-frontend-lint-slim 2026-07-20 21:05:18 +08:00
gitea-actions bot commented 2026-07-20 21:05:36 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #655 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #655 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#655
Delete Branch "p2-5-frontend-lint-slim"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?