xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 3 Actions Packages Projects Releases 7 Wiki Activity

fix(e2e): 精确匹配创建计划接口路径 + 增加错误调试日志 #668

Merged
auto-approve-bot merged 1 commits from fix/e2e-template-editors-path-precise into develop 2026-07-21 07:48:50 +08:00
Conversation 5 Commits 1 Files Changed 1
+15 -4
xiaoxia commented 2026-07-21 07:46:03 +08:00
Owner
Copy Link
Copy Source

问题

Staging E2E 测试在点确认生成后，创建计划接口返回非 2xx，但不知道具体错误。

修复

  1. 精确匹配路径：waitForResponse 从 includes("/template-editors") 改为匹配路径结尾，避免误匹配到 POST /template-editors/{id}/clips、/ai-recommend 等其他 POST 接口
  2. 增加调试日志：接口失败时打印 status/url/body，方便定位具体错误

先合并进去看 develop E2E 的具体错误信息，再针对性修复。

### 问题 Staging E2E 测试在点确认生成后，创建计划接口返回非 2xx，但不知道具体错误。 ### 修复 1. **精确匹配路径**：`waitForResponse` 从 `includes("/template-editors")` 改为匹配路径结尾，避免误匹配到 `POST /template-editors/{id}/clips`、`/ai-recommend` 等其他 POST 接口 2. **增加调试日志**：接口失败时打印 status/url/body，方便定位具体错误 先合并进去看 develop E2E 的具体错误信息，再针对性修复。
xiaoxia added 1 commit 2026-07-21 07:46:03 +08:00
fix(e2e): 精确匹配创建计划接口路径+加错误调试日志
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 24s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m34s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m35s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m35s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 2m43s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 35s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 2m50s
Details
AI Code Review / AI Code Review (pull_request) Successful in 4m18s
Details
e8587576c7 
1. 将 waitForResponse 从模糊匹配 /template-editors 改为精确匹配路径末尾
   避免匹配到 POST /template-editors/{id}/clips 等其他 POST 接口

2. 接口失败时打印 status/url/body 方便排查
auto-approve-bot approved these changes 2026-07-21 07:47:42 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-21 07:47:42 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
gitea-actions bot commented 2026-07-21 07:47:44 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #668
预览链接 https://pr-668.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #668 | | 预览链接 | [https://pr-668.preview.xiaoxiajianji.com](https://pr-668.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot merged commit 4f7da8e793 into develop 2026-07-21 07:48:50 +08:00
auto-approve-bot deleted branch fix/e2e-template-editors-path-precise 2026-07-21 07:48:50 +08:00
gitea-actions bot commented 2026-07-21 07:49:26 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #668 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #668 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
auto-approve-bot commented 2026-07-21 07:50:16 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #668

⚠️ 问题（2个需要修改）

  1. apps/web/e2e/core-generation.spec.ts 第226行：waitForResponse 回调中直接使用 new URL(url) 缺乏异常保护。

    • 原因：waitForResponse 的回调函数会在页面发起的每个网络响应时执行。如果页面中存在非标准 URL（例如 about:blank、data: 协议链接或格式错误的 URL），new URL() 构造函数会抛出 TypeError，导致整个测试流程意外崩溃，而不是简单地忽略该响应。
    • 后果：导致 E2E 测试不稳定，出现难以排查的 "Invalid URL" 错误。
    • 建议：使用 try-catch 包裹 URL 解析逻辑，捕获异常时返回 false 以跳过该响应。

  2. apps/web/e2e/core-generation.spec.ts 第242行：在错误处理逻辑中读取响应体未捕获异常。

    • 原因：当 planResp.ok() 为 false 时，代码尝试通过 planResp.text() 读取响应体以打印日志。如果网络连接中断或响应体已被损坏/消耗，text() 方法本身可能会抛出异常（如 "Failed to get response body"）。
    • 后果：这将掩盖原始的 HTTP 错误（如 500/404），导致测试报错信息变成读取 Body 失败，而非接口调用失败，干扰问题定位。
    • 建议：将 console.error 相关逻辑包裹在 try-catch 中，确保即使读取 Body 失败，也能打印出状态码和 URL。

💡 建议（0个可选）

无

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能无明显问题

🤖 由 AI 代码审查机器人自动生成 | 2026-07-21 07:50:16 | 模型:

## 代码审查结果 - PR #668 ### ⚠️ 问题（2个需要修改） 1. **apps/web/e2e/core-generation.spec.ts 第226行**：`waitForResponse` 回调中直接使用 `new URL(url)` 缺乏异常保护。 - **原因**：`waitForResponse` 的回调函数会在页面发起的**每个**网络响应时执行。如果页面中存在非标准 URL（例如 `about:blank`、`data:` 协议链接或格式错误的 URL），`new URL()` 构造函数会抛出 `TypeError`，导致整个测试流程意外崩溃，而不是简单地忽略该响应。 - **后果**：导致 E2E 测试不稳定，出现难以排查的 "Invalid URL" 错误。 - **建议**：使用 `try-catch` 包裹 URL 解析逻辑，捕获异常时返回 `false` 以跳过该响应。 2. **apps/web/e2e/core-generation.spec.ts 第242行**：在错误处理逻辑中读取响应体未捕获异常。 - **原因**：当 `planResp.ok()` 为 `false` 时，代码尝试通过 `planResp.text()` 读取响应体以打印日志。如果网络连接中断或响应体已被损坏/消耗，`text()` 方法本身可能会抛出异常（如 "Failed to get response body"）。 - **后果**：这将掩盖原始的 HTTP 错误（如 500/404），导致测试报错信息变成读取 Body 失败，而非接口调用失败，干扰问题定位。 - **建议**：将 `console.error` 相关逻辑包裹在 `try-catch` 中，确保即使读取 Body 失败，也能打印出状态码和 URL。 ### 💡 建议（0个可选） 无 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能无明显问题 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-21 07:50:16 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#668
Delete Branch "fix/e2e-template-editors-path-precise"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?