ci: Validate并行化,拆分为代码质量/类型检查/迁移验证三个并行job #700

Merged
xiaoxia merged 4 commits from ci/validate-parallelization into develop 2026-07-22 09:22:54 +08:00
Owner

背景

Validate目前单job串行跑8项检查,总耗时~2.8分钟。

方案

拆分为3个并行job,预计Validate总耗时从2.8min降到~1.5min(-46%):

  • Validate - Code Quality: 密钥检测/black/isort/ruff/bandit/pip-audit/vulture/release脚本校验
  • Validate - Type Check (mypy): Mypy类型检查
  • Validate - Migration (alembic): Alembic迁移验证(需要PG)

改动

  • 新增 scripts/ci/validate_code_quality.sh
  • 新增 scripts/ci/validate_mypy.sh
  • 新增 scripts/ci/validate_migration.sh
  • ci-pipeline.yml新增3个并行Validate job

备注

本PR保留旧Validate job做对照验证,验证稳定后在下一个PR移除旧job并更新分支保护配置。

## 背景 Validate目前单job串行跑8项检查,总耗时~2.8分钟。 ## 方案 拆分为3个并行job,预计Validate总耗时从2.8min降到~1.5min(-46%): - **Validate - Code Quality**: 密钥检测/black/isort/ruff/bandit/pip-audit/vulture/release脚本校验 - **Validate - Type Check (mypy)**: Mypy类型检查 - **Validate - Migration (alembic)**: Alembic迁移验证(需要PG) ## 改动 - 新增 scripts/ci/validate_code_quality.sh - 新增 scripts/ci/validate_mypy.sh - 新增 scripts/ci/validate_migration.sh - ci-pipeline.yml新增3个并行Validate job ## 备注 本PR保留旧Validate job做对照验证,验证稳定后在下一个PR移除旧job并更新分支保护配置。
xiaoxia added 4 commits 2026-07-22 09:07:55 +08:00
ci: Validate并行化-拆分为CodeQuality/TypeCheck/Migration三个并行job
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 33s
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m3s
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m3s
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 1m45s
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 40s
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 58s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 45s
AI Code Review / AI Code Review (pull_request) Successful in 7m14s
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 11m13s
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 10m47s
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 2m9s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 37s
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m48s
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m11s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 22m29s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 35m32s
f30af27762

🚀 预览环境已部署

项目 详情
PR号 #700
预览链接 https://pr-700.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后,预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #700 | | 预览链接 | [https://pr-700.preview.xiaoxiajianji.com](https://pr-700.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据,请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后,预览环境会自动清理。
Collaborator

代码审查结果 - PR #700

⚠️ 问题(2个需要修改)

  1. scripts/ci/validate_migration.sh 第110行:硬编码数据库密码存在安全风险。脚本中直接写死了 SHARED_PG_PASSWORD="ci_pg_2026!"。如果该仓库被公开或 CI 日志泄露,数据库将面临安全风险。建议使用 CI Secrets(如 ${SHARED_PG_PASSWORD})注入该凭证。
  2. scripts/ci/validate_code_quality.sh 第180行:缺少文件存在性校验。脚本直接对 scripts/backup_postgres.sh 等三个文件执行 bash -n 语法检查。由于脚本开头设置了 set -eu,如果这些文件不存在(例如在其他分支或 Fork 项目中运行),会导致 CI 任务异常退出。建议在执行前添加 [ -f "$file" ] 判断。

💡 建议(1个可选)

  1. scripts/ci/validate_migration.sh detect_docker_host 函数:Docker 宿主机检测的默认兜底值为 127.0.0.1 存在逻辑隐患。在 Docker-in-Docker (DooD) 环境下,如果前面的自动检测(如 host.docker.internal、网关探测)均失败,函数会返回 127.0.0.1。此时脚本会尝试连接 CI 容器自身的本地回环地址,而非宿主机或兄弟容器上的数据库,导致连接失败。建议在无法确定宿主机 IP 时直接报错退出,而不是使用不安全的默认值。

格式检查通过 | 逻辑审查需修改 | ⚠️ 建议关注性能


🤖 由 AI 代码审查机器人自动生成 | 2026-07-22 09:18:40 | 模型:

## 代码审查结果 - PR #700 ### ⚠️ 问题(2个需要修改) 1. **scripts/ci/validate_migration.sh 第110行**:硬编码数据库密码存在安全风险。脚本中直接写死了 `SHARED_PG_PASSWORD="ci_pg_2026!"`。如果该仓库被公开或 CI 日志泄露,数据库将面临安全风险。建议使用 CI Secrets(如 `${SHARED_PG_PASSWORD}`)注入该凭证。 2. **scripts/ci/validate_code_quality.sh 第180行**:缺少文件存在性校验。脚本直接对 `scripts/backup_postgres.sh` 等三个文件执行 `bash -n` 语法检查。由于脚本开头设置了 `set -eu`,如果这些文件不存在(例如在其他分支或 Fork 项目中运行),会导致 CI 任务异常退出。建议在执行前添加 `[ -f "$file" ]` 判断。 ### 💡 建议(1个可选) 1. **scripts/ci/validate_migration.sh detect_docker_host 函数**:Docker 宿主机检测的默认兜底值为 `127.0.0.1` 存在逻辑隐患。在 Docker-in-Docker (DooD) 环境下,如果前面的自动检测(如 host.docker.internal、网关探测)均失败,函数会返回 `127.0.0.1`。此时脚本会尝试连接 CI 容器自身的本地回环地址,而非宿主机或兄弟容器上的数据库,导致连接失败。建议在无法确定宿主机 IP 时直接报错退出,而不是使用不安全的默认值。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-22 09:18:40 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia merged commit 6bde806462 into develop 2026-07-22 09:22:54 +08:00

🗑️ 预览环境已清理

PR #700 已关闭或合并,对应的预览环境已被清理。

如有需要,可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #700 已关闭或合并,对应的预览环境已被清理。 > 如有需要,可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.