xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix(ci): 修复Vitest增量测试 --related 参数错误，应是 related 子命令 #711

Merged
xiaoxia merged 1 commits from fix/vitest-related-flag-bug into develop 2026-07-22 14:49:05 +08:00
Conversation 5 Commits 1 Files Changed 1
+2 -2
xiaoxia commented 2026-07-22 14:16:28 +08:00
Owner
Copy Link
Copy Source

问题

scripts/ci/vitest_incremental.sh 第65行使用了错误的vitest参数写法：

npx --no-install vitest run --related $CHANGED_FILES

Vitest 的 related 是子命令，不是 flag，正确写法是 vitest run related <files>。

修复

  • 第65行：--related → related（子命令，无 -- 前缀）
  • 注释同步修正

影响

修复后，前端PR的增量单测（Frontend Unit Tests）能正常执行，之前全挂。

## 问题 `scripts/ci/vitest_incremental.sh` 第65行使用了错误的vitest参数写法： ```bash npx --no-install vitest run --related $CHANGED_FILES ``` Vitest 的 `related` 是**子命令**，不是 flag，正确写法是 `vitest run related <files>`。 ## 修复 - 第65行：`--related` → `related`（子命令，无 `--` 前缀） - 注释同步修正 ## 影响 修复后，前端PR的增量单测（Frontend Unit Tests）能正常执行，之前全挂。
xiaoxia added 1 commit 2026-07-22 14:16:28 +08:00
fix(ci): 修复Vitest增量测试--related参数错误，应是related子命令
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 55s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 24s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 1m43s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 36s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 24s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 35s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m33s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m42s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 36s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 5m38s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 1m49s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m48s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 17m15s
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 42m35s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 38s
Details
229cca8630
auto-approve-bot approved these changes 2026-07-22 14:26:04 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-22 14:26:04 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot commented 2026-07-22 14:26:05 +08:00
Collaborator
Copy Link
Copy Source

📊 审查概览

  • 整体评价：需修改
  • 严重问题数量：1 个
  • 一般建议数量：1 个

❌ 需修改的问题（严重）

  1. [scripts/ci/vitest_incremental.sh: 66] Vitest 命令参数使用错误
    • 问题描述：将 --related 修改为 related 会导致增量测试逻辑失效。Vitest 的 CLI 规范中，--related 是一个选项（Flag），用于指定根据文件名关联运行测试，而不是子命令。修改后，related 会被 Vitest 当作测试文件名或匹配模式处理，导致无法正确筛选受影响的测试用例。
    • 修改建议：请回退此处的修改，恢复使用 --related 标志。正确的命令应为：npx --no-install vitest run --related $CHANGED_FILES。

💡 改进建议（一般）

  1. [scripts/ci/vitest_incremental.sh: 66] Shell 变量引用建议加引号
    • 具体内容：变量 $CHANGED_FILES 未被双引号包裹。虽然 CI 环境下的文件名通常不包含空格，但为了防止文件名中意外出现空格导致参数解析错误（Shell 分词），建议使用 "$CHANGED_FILES"。

✅ 良好实践

  • 脚本正确使用了 set +e 和 set -e 来捕获测试命令的退出码，确保测试失败能正确传播，而不中断脚本的执行流。
  • 注释清晰地记录了修改意图，方便了审查（尽管本次修改的逻辑是错误的）。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能无明显问题

🤖 由 AI 代码审查机器人自动生成 | 2026-07-22 14:26:05 | 模型:

### 📊 审查概览 - 整体评价：需修改 - 严重问题数量：1 个 - 一般建议数量：1 个 ### ❌ 需修改的问题（严重） 1. **[scripts/ci/vitest_incremental.sh: 66] Vitest 命令参数使用错误** - 问题描述：将 `--related` 修改为 `related` 会导致增量测试逻辑失效。Vitest 的 CLI 规范中，`--related` 是一个选项（Flag），用于指定根据文件名关联运行测试，而不是子命令。修改后，`related` 会被 Vitest 当作测试文件名或匹配模式处理，导致无法正确筛选受影响的测试用例。 - 修改建议：请回退此处的修改，恢复使用 `--related` 标志。正确的命令应为：`npx --no-install vitest run --related $CHANGED_FILES`。 ### 💡 改进建议（一般） 1. **[scripts/ci/vitest_incremental.sh: 66] Shell 变量引用建议加引号** - 具体内容：变量 `$CHANGED_FILES` 未被双引号包裹。虽然 CI 环境下的文件名通常不包含空格，但为了防止文件名中意外出现空格导致参数解析错误（Shell 分词），建议使用 `"$CHANGED_FILES"`。 ### ✅ 良好实践 - 脚本正确使用了 `set +e` 和 `set -e` 来捕获测试命令的退出码，确保测试失败能正确传播，而不中断脚本的执行流。 - 注释清晰地记录了修改意图，方便了审查（尽管本次修改的逻辑是错误的）。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能无明显问题 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-22 14:26:05 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-07-22 14:26:34 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #711
预览链接 https://pr-711.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #711 | | 预览链接 | [https://pr-711.preview.xiaoxiajianji.com](https://pr-711.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia merged commit a4a279ae2b into develop 2026-07-22 14:49:05 +08:00
gitea-actions bot commented 2026-07-22 15:13:08 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #711 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #711 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#711
Delete Branch "fix/vitest-related-flag-bug"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?