xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 9 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix(ci): 格式化pr_auto_scan.py修复develop分支Code Quality门禁 #741

Merged
xiaoxia merged 1 commits from fix/ci-pr-auto-scan-black-format into develop 2026-07-22 20:52:24 +08:00
Conversation 3 Commits 1 Files Changed 1
+69 -58
xiaoxia commented 2026-07-22 20:32:03 +08:00
Owner
Copy Link
Copy Source

问题

develop分支Code Quality门禁失败，原因是scripts/ci/pr_auto_scan.py（#722新增）未通过black格式检查。

修复

  • black格式化 pr_auto_scan.py
  • isort整理import

影响

  • 修复develop分支Code Quality失败问题
  • 不影响业务逻辑
## 问题 develop分支Code Quality门禁失败，原因是`scripts/ci/pr_auto_scan.py`（#722新增）未通过black格式检查。 ## 修复 - black格式化 pr_auto_scan.py - isort整理import ## 影响 - 修复develop分支Code Quality失败问题 - 不影响业务逻辑
xiaoxia added 1 commit 2026-07-22 20:32:03 +08:00
fix(ci): 格式化pr_auto_scan.py修复develop分支Code Quality门禁
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 41s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 49s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 53s
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 56s
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m2s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 43s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 2m34s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m39s
Details
CI/CD Pipeline / Integration Tests (pull_request) Failing after 2m43s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m45s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 4m41s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 4m59s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 5m8s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 13m0s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 9s
Details
b1913f48e2
gitea-actions bot commented 2026-07-22 20:33:28 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #741
预览链接 https://pr-741.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #741 | | 预览链接 | [https://pr-741.preview.xiaoxiajianji.com](https://pr-741.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-07-22 20:35:51 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #741

⚠️ 问题（4个需要修改）

  1. scripts/ci/pr_auto_scan.py 第40行：e.read() 在条件表达式中被调用了两次。第一次调用消耗了错误流，导致第二次调用返回空字节，json.loads 解析空字符串将抛出 JSONDecodeError 异常，导致错误处理失败。
  2. scripts/ci/pr_auto_scan.py 第26-28行：SSL证书验证被完全禁用（verify_mode = ssl.CERT_NONE），虽然在内网环境常见，但存在中间人攻击（MITM）的安全隐患。
  3. scripts/ci/pr_auto_scan.py 第163行：merge_pr 函数中硬编码 time.sleep(30)。默认 max-prs 为 20，若处理多个 PR，总阻塞时间可能超过 10 分钟，导致脚本运行时长超过 5 分钟的调度间隔，造成作业重叠或积压。
  4. scripts/ci/pr_auto_scan.py 第268行：check_required_contexts 内部调用了 get_commit_status API。在 main 函数中，针对同一个 SHA 分别调用了两次（第 268 行和第 291 行）来检查不同的上下文，导致重复的 API 请求，浪费资源且增加延迟。

💡 建议（1个可选）

  1. scripts/ci/pr_auto_scan.py 第244行：get_open_prs 已经通过 base 参数向 API 发起了过滤请求，此处 if base_ref != args.base 的检查显得冗余，除非为了防御 API 返回异常数据，否则可移除。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能

🤖 由 AI 代码审查机器人自动生成 | 2026-07-22 20:35:51 | 模型:

## 代码审查结果 - PR #741 ### ⚠️ 问题（4个需要修改） 1. **scripts/ci/pr_auto_scan.py 第40行**：`e.read()` 在条件表达式中被调用了两次。第一次调用消耗了错误流，导致第二次调用返回空字节，`json.loads` 解析空字符串将抛出 `JSONDecodeError` 异常，导致错误处理失败。 2. **scripts/ci/pr_auto_scan.py 第26-28行**：SSL证书验证被完全禁用（`verify_mode = ssl.CERT_NONE`），虽然在内网环境常见，但存在中间人攻击（MITM）的安全隐患。 3. **scripts/ci/pr_auto_scan.py 第163行**：`merge_pr` 函数中硬编码 `time.sleep(30)`。默认 `max-prs` 为 20，若处理多个 PR，总阻塞时间可能超过 10 分钟，导致脚本运行时长超过 5 分钟的调度间隔，造成作业重叠或积压。 4. **scripts/ci/pr_auto_scan.py 第268行**：`check_required_contexts` 内部调用了 `get_commit_status` API。在 `main` 函数中，针对同一个 SHA 分别调用了两次（第 268 行和第 291 行）来检查不同的上下文，导致重复的 API 请求，浪费资源且增加延迟。 ### 💡 建议（1个可选） 1. **scripts/ci/pr_auto_scan.py 第244行**：`get_open_prs` 已经通过 `base` 参数向 API 发起了过滤请求，此处 `if base_ref != args.base` 的检查显得冗余，除非为了防御 API 返回异常数据，否则可移除。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-22 20:35:51 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia merged commit a75f749b39 into develop 2026-07-22 20:52:24 +08:00
xiaoxia deleted branch fix/ci-pr-auto-scan-black-format 2026-07-22 20:52:24 +08:00
gitea-actions bot commented 2026-07-22 20:52:33 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #741 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #741 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#741
Delete Branch "fix/ci-pr-auto-scan-black-format"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?