xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 9 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

style: 修复2个文件ruff告警+格式化对齐（smart_asset_selector + test_ai_service） #759

Merged
auto-approve-bot merged 1 commits from fix/ruff-alerts-2files into develop 2026-07-23 17:57:33 +08:00
Conversation 4 Commits 1 Files Changed 2
+22 -25
xiaoxia commented 2026-07-23 17:51:48 +08:00
Owner
Copy Link
Copy Source

修复develop上残留的ruff check告警，确保Code Quality门禁全绿。

变更文件：

  • apps/api/app/services/smart_asset_selector.py：删未用math import + name→_name + zip()加strict=False
  • tests/unit/test_ai_service.py：key→_key

ruff + black + isort 全部验证通过。

修复develop上残留的ruff check告警，确保Code Quality门禁全绿。 **变更文件：** - `apps/api/app/services/smart_asset_selector.py`：删未用`math` import + `name`→`_name` + `zip()`加`strict=False` - `tests/unit/test_ai_service.py`：`key`→`_key` ruff + black + isort 全部验证通过。
xiaoxia added 1 commit 2026-07-23 17:51:48 +08:00
style: 修复2个文件ruff告警+格式化对齐（smart_asset_selector + test_ai_service）
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 19s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 46s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m18s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m34s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 27s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m42s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m39s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 11s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 4m6s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 3m23s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 24s
Details
AI Code Review / AI Code Review (pull_request) Successful in 5m42s
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 4m32s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 7m13s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 13m25s
Details
407261cf51
auto-approve-bot approved these changes 2026-07-23 17:56:33 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-23 17:56:33 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot merged commit 27cb7381ad into develop 2026-07-23 17:57:33 +08:00
auto-approve-bot deleted branch fix/ruff-alerts-2files 2026-07-23 17:57:34 +08:00
gitea-actions bot commented 2026-07-23 17:58:03 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #759 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #759 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
auto-approve-bot commented 2026-07-23 17:59:34 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #759

⚠️ 问题（0个需要修改）

无

💡 建议（1个可选）

  1. apps/api/app/services/smart_asset_selector.py 第295行：建议简化循环逻辑
    • 说明：当前代码使用 zip(buckets, bucket_names, strict=False) 进行遍历，但循环体中并未使用 name（已重命名为 _name）。这种写法引入了不必要的依赖关系，如果 bucket_names 列表长度短于 buckets，会导致部分桶被静默忽略（尽管目前看来两者长度是固定的）。
    • 建议：直接遍历 buckets 列表即可，即 for bucket in buckets:，代码更简洁且逻辑更清晰。

✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好

🤖 由 AI 代码审查机器人自动生成 | 2026-07-23 09:59:34 | 模型:

## 代码审查结果 - PR #759 ### ⚠️ 问题（0个需要修改） 无 ### 💡 建议（1个可选） 1. **apps/api/app/services/smart_asset_selector.py 第295行**：建议简化循环逻辑 - **说明**：当前代码使用 `zip(buckets, bucket_names, strict=False)` 进行遍历，但循环体中并未使用 `name`（已重命名为 `_name`）。这种写法引入了不必要的依赖关系，如果 `bucket_names` 列表长度短于 `buckets`，会导致部分桶被静默忽略（尽管目前看来两者长度是固定的）。 - **建议**：直接遍历 `buckets` 列表即可，即 `for bucket in buckets:`，代码更简洁且逻辑更清晰。 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-23 09:59:34 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#759
Delete Branch "fix/ruff-alerts-2files"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?