xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 10 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix: 状态枚举添加_missing_兼容历史脏数据，修复Staging模板生成接口500 #809 #835

Merged
xiaoxia merged 1 commits from bugfix/809-generation-task-status-missing into develop 2026-07-25 10:04:00 +08:00
Conversation 2 Commits 1 Files Changed 4
+144
xiaoxia commented 2026-07-24 18:01:51 +08:00
Owner
Copy Link
Copy Source

问题

Staging 环境模板生成接口和任务列表接口返回500（#809），E2E测试失败。

根因

Staging PostgreSQL 有历史脏数据（早期版本的状态值如 success/done 等），GenerationTaskStatus 枚举缺少 _missing_ 兼容方法，从 DB 读取时枚举转换抛 ValueError，触发500。

两个500接口的共性：都调用 generation_task_repository.list_by_user_filtered() → _to_domain() → GenerationTaskStatus(model.status) 枚举转换。

同类问题：EditPlanStatus 和 EditPlanClipStatus 也缺 _missing_，有同样的潜在风险，一并修复。

修复

参照 AssetStatus 和 ClassificationJobStatus 的已有模式，给三个枚举都加上 _missing_ 方法：

  • 兼容常见历史别名（success/done/fail/error/cancel 等）
  • 未知值兜底到初始态（PENDING/DRAFT），不阻塞业务
  • 大小写不敏感 + 自动 strip 空格

改动

  • packages/domain/generation_task.py：GenerationTaskStatus._missing_
  • packages/domain/edit_plan.py：EditPlanStatus._missing_
  • packages/domain/edit_plan_clip.py：EditPlanClipStatus._missing_
  • tests/unit/test_generation_task_status_enum.py：32个兼容性单测（全绿）
## 问题 Staging 环境模板生成接口和任务列表接口返回500（#809），E2E测试失败。 ## 根因 Staging PostgreSQL 有历史脏数据（早期版本的状态值如 `success`/`done` 等），`GenerationTaskStatus` 枚举缺少 `_missing_` 兼容方法，从 DB 读取时枚举转换抛 `ValueError`，触发500。 两个500接口的共性：都调用 `generation_task_repository.list_by_user_filtered()` → `_to_domain()` → `GenerationTaskStatus(model.status)` 枚举转换。 同类问题：`EditPlanStatus` 和 `EditPlanClipStatus` 也缺 `_missing_`，有同样的潜在风险，一并修复。 ## 修复 参照 `AssetStatus` 和 `ClassificationJobStatus` 的已有模式，给三个枚举都加上 `_missing_` 方法： - 兼容常见历史别名（success/done/fail/error/cancel 等） - 未知值兜底到初始态（PENDING/DRAFT），不阻塞业务 - 大小写不敏感 + 自动 strip 空格 ## 改动 - `packages/domain/generation_task.py`：`GenerationTaskStatus._missing_` - `packages/domain/edit_plan.py`：`EditPlanStatus._missing_` - `packages/domain/edit_plan_clip.py`：`EditPlanClipStatus._missing_` - `tests/unit/test_generation_task_status_enum.py`：32个兼容性单测（全绿）
xiaoxia added 1 commit 2026-07-25 00:06:38 +08:00
fix: 状态枚举添加_missing_兼容历史脏数据，修复Staging 500 #809
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 37s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m15s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 44s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m6s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 44s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 37s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 24s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m6s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m57s
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m52s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m40s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 2m27s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 16m20s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m37s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 9s
Details
528bcaf59f 
根因：Staging PostgreSQL有历史脏数据（如success/done等旧状态值），
GenerationTaskStatus/EditPlanStatus/EditPlanClipStatus枚举缺少_missing_
兼容方法，导致枚举转换抛ValueError触发500。

修复：参照AssetStatus/ClassificationJobStatus的模式，给三个枚举都加上
_missing_方法，兼容常见历史别名，未知值兜底到初始态（不阻塞业务）。

修改范围：
- packages/domain/generation_task.py: GenerationTaskStatus._missing_
- packages/domain/edit_plan.py: EditPlanStatus._missing_
- packages/domain/edit_plan_clip.py: EditPlanClipStatus._missing_
- tests/unit/test_generation_task_status_enum.py: 32个兼容性单测
xiaoxia force-pushed bugfix/809-generation-task-status-missing from 79a0ab457c to 528bcaf59f 2026-07-25 00:06:38 +08:00 Compare
auto-approve-bot commented 2026-07-25 00:18:53 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #835

⚠️ 问题（0个需要修改）

无

💡 建议（2个可选）

  1. packages/domain/generation_task.py 第53行 (及其他文件类似行)：_missing_ 方法中的映射列表包含冗余值。
    • 具体内容：代码中检查 normalized in ("done", ..., "completed")，由于枚举中已定义 COMPLETED = "completed"，当传入 "completed" 时 Python 会直接匹配成功，根本不会调用 _missing_。建议移除列表中与枚举值完全一致的字符串（如 "completed", "failed", "cancelled" 等），以保持代码整洁，避免误导。
  2. tests/unit/test_generation_task_status_enum.py：测试覆盖率不完整。
    • 具体内容：PR 同时修改了 EditPlanStatus 和 EditPlanClipStatus 的逻辑，但仅新增了 GenerationTaskStatus 的单元测试。虽然逻辑相似，但为了防止未来修改导致的不一致，建议补充另外两个枚举的兼容性测试。

✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能无明显问题

🤖 由 AI 代码审查机器人自动生成 | 2026-07-24 16:18:53 | 模型:

## 代码审查结果 - PR #835 ### ⚠️ 问题（0个需要修改） 无 ### 💡 建议（2个可选） 1. **packages/domain/generation_task.py 第53行 (及其他文件类似行)**：`_missing_` 方法中的映射列表包含冗余值。 - 具体内容：代码中检查 `normalized in ("done", ..., "completed")`，由于枚举中已定义 `COMPLETED = "completed"`，当传入 `"completed"` 时 Python 会直接匹配成功，根本不会调用 `_missing_`。建议移除列表中与枚举值完全一致的字符串（如 `"completed"`, `"failed"`, `"cancelled"` 等），以保持代码整洁，避免误导。 2. **tests/unit/test_generation_task_status_enum.py**：测试覆盖率不完整。 - 具体内容：PR 同时修改了 `EditPlanStatus` 和 `EditPlanClipStatus` 的逻辑，但仅新增了 `GenerationTaskStatus` 的单元测试。虽然逻辑相似，但为了防止未来修改导致的不一致，建议补充另外两个枚举的兼容性测试。 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能无明显问题 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-24 16:18:53 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia merged commit be0b4f4dac into develop 2026-07-25 10:04:00 +08:00
xiaoxia deleted branch bugfix/809-generation-task-status-missing 2026-07-25 10:04:00 +08:00
gitea-actions bot commented 2026-07-25 10:04:10 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #835 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #835 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#835
Delete Branch "bugfix/809-generation-task-status-missing"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?