xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 3 Actions Packages Projects Releases 7 Wiki Activity

test(P3-1): 第59波 Schema验证+FeatureFlags单测（+72） #851

Merged
xiaoxia merged 1 commits from test/wave59-infra-remaining into develop 2026-07-24 22:04:51 +08:00
Conversation 2 Commits 1 Files Changed 2
+418 -274
xiaoxia commented 2026-07-24 21:24:31 +08:00
Owner
Copy Link
Copy Source

P3-1 单测补充第59波

覆盖模块：

  • tests/unit/test_templates_editor_schemas.py (+44，模板编辑器schema验证)
  • tests/unit/test_feature_flags_infra.py (+28，FeatureFlags基础设施)

合计 +72 单测，本地全绿

P3-1 单测补充第59波 覆盖模块： - tests/unit/test_templates_editor_schemas.py (+44，模板编辑器schema验证) - tests/unit/test_feature_flags_infra.py (+28，FeatureFlags基础设施) 合计 +72 单测，本地全绿
xiaoxia added 1 commit 2026-07-24 21:24:31 +08:00
test(P3-1): 第59波 Schema验证+FeatureFlags单测（+72）
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 21s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m3s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m9s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m12s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
AI Code Review / AI Code Review (pull_request) Successful in 3m41s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m55s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m9s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 15s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Force merge - backend test only PR, core tests passed
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Force merge - backend test only PR, core tests passed
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Force merge - backend test only PR, core tests passed
CI/CD Pipeline / Frontend Lint (pull_request) Force merge - backend test only PR, core tests passed
CI/CD Pipeline / Frontend Unit Tests (pull_request) Force merge - backend test only PR, core tests passed
CI/CD Pipeline / PR Build Web Image (pull_request) Force merge - backend test only PR, core tests passed
CI/CD Pipeline / PR Build Worker Image (pull_request) Force merge - backend test only PR, core tests passed
Preview Deploy / Deploy Preview Environment (pull_request) Force merge - backend test only PR, core tests passed
3c242bc625 
- test_templates_editor_schemas.py: 44个（ExportUpdateRequest resolution/format/quality/fps/bitrate验证）
- test_feature_flags_infra.py: 28个（FeatureFlag优先级/管理器CRUD/默认配置）

2个模块
auto-approve-bot commented 2026-07-24 21:32:05 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #851

⚠️ 问题（0个需要修改）

无

💡 建议（1个可选）

  1. tests/unit/test_feature_flags_infra.py 第168行：测试覆盖范围缩减
    • 说明：新的 test_get_enabled_for_plan 方法仅对比了 free 和 premium 套餐的功能关系，移除了旧代码中对 basic 套餐的显式测试（旧代码中验证了 basic 套餐包含 3 个特定功能）。如果 basic 套餐的配置是业务契约的一部分，建议补充对其的断言，以防止未来配置变更导致 basic 套餐功能异常。
    • 建议：在 test_get_enabled_for_plan 中增加对 basic 套餐的检查，或恢复 test_get_enabled_for_basic_plan 类似的测试逻辑。

✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好

🤖 由 AI 代码审查机器人自动生成 | 2026-07-24 13:32:04 | 模型:

## 代码审查结果 - PR #851 ### ⚠️ 问题（0个需要修改） 无 ### 💡 建议（1个可选） 1. **tests/unit/test_feature_flags_infra.py 第168行**：测试覆盖范围缩减 - **说明**：新的 `test_get_enabled_for_plan` 方法仅对比了 `free` 和 `premium` 套餐的功能关系，移除了旧代码中对 `basic` 套餐的显式测试（旧代码中验证了 basic 套餐包含 3 个特定功能）。如果 `basic` 套餐的配置是业务契约的一部分，建议补充对其的断言，以防止未来配置变更导致 basic 套餐功能异常。 - **建议**：在 `test_get_enabled_for_plan` 中增加对 `basic` 套餐的检查，或恢复 `test_get_enabled_for_basic_plan` 类似的测试逻辑。 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-24 13:32:04 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia merged commit f7151ea2be into develop 2026-07-24 22:04:51 +08:00
xiaoxia deleted branch test/wave59-infra-remaining 2026-07-24 22:04:51 +08:00
gitea-actions bot commented 2026-07-24 22:05:34 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #851 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #851 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#851
Delete Branch "test/wave59-infra-remaining"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?