xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 16 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

refactor(voices): Phase 1 - extract types, constants and utils #873

Closed
xiaoxia wants to merge 1 commits from refactor/voice-library-phase1 into develop
pull from: refactor/voice-library-phase1
merge into: xiaoxia:develop
Conversation 2 Commits 1 Files Changed 9
+5257 -156
xiaoxia commented 2026-07-25 11:27:48 +08:00
Owner
Copy Link
Copy Source

VoiceLibrary Phase 1 重构

按 VoiceMaterialLibrary 重构套路，将 VoiceLibrary.tsx 中的类型、常量、工具函数抽离到独立文件。

改动内容

新增文件 (4 + 1 test):

  • apps/web/src/pages/voices/types.ts — 类型定义、接口、映射函数
  • apps/web/src/pages/voices/constants.ts — 常量、选项配置
  • apps/web/src/pages/voices/utils/format.ts — 格式化工具函数
  • apps/web/src/pages/voices/utils/audio.ts — 音频相关工具函数
  • apps/web/src/test/pages/voices/smoke.test.tsx — smoke test

主文件变化:

  • VoiceLibrary.tsx: 1783 行 → 1647 行（减少 136 行）

质量保证

  • 0 any、0 ts-ignore、0 eslint-disable
  • 所有文件权限 644
  • import 路径统一使用 @/pages/voices/xxx
  • 功能完全等价，无任何行为变化

后续 Phase 规划

  • Phase 2: 抽离子组件（VoiceCard、CloneVoiceCard、CloneDetailModal 等）
  • Phase 3: 抽离 hooks（数据查询、播放控制、上传逻辑等）
## VoiceLibrary Phase 1 重构 按 VoiceMaterialLibrary 重构套路，将 VoiceLibrary.tsx 中的类型、常量、工具函数抽离到独立文件。 ### 改动内容 **新增文件 (4 + 1 test):** - `apps/web/src/pages/voices/types.ts` — 类型定义、接口、映射函数 - `apps/web/src/pages/voices/constants.ts` — 常量、选项配置 - `apps/web/src/pages/voices/utils/format.ts` — 格式化工具函数 - `apps/web/src/pages/voices/utils/audio.ts` — 音频相关工具函数 - `apps/web/src/test/pages/voices/smoke.test.tsx` — smoke test **主文件变化:** - VoiceLibrary.tsx: 1783 行 → 1647 行（减少 136 行） ### 质量保证 - 0 any、0 ts-ignore、0 eslint-disable - 所有文件权限 644 - import 路径统一使用 `@/pages/voices/xxx` - 功能完全等价，无任何行为变化 ### 后续 Phase 规划 - Phase 2: 抽离子组件（VoiceCard、CloneVoiceCard、CloneDetailModal 等） - Phase 3: 抽离 hooks（数据查询、播放控制、上传逻辑等）
xiaoxia force-pushed refactor/voice-library-phase1 from 576684398f to 00ff978352 2026-07-25 11:37:04 +08:00 Compare
xiaoxia added 1 commit 2026-07-25 12:15:01 +08:00
refactor(voices): Phase 1 - extract types, constants and utils
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 35s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m15s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m1s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 54s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m1s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m50s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 25s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m23s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 43s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 4m28s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m42s
Details
AI Code Review / AI Code Review (pull_request) Successful in 5m3s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 4m56s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 5m58s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 16s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Failing after 16s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m46s
Details
ae78918ae4 
Extract types, constants, and utility functions from VoiceLibrary.tsx
into separate files following the same pattern as VoiceMaterialLibrary.

New files:
- types.ts: VoiceGender, VoiceLanguage, TabKey, display interfaces, mappers
- constants.ts: gender options, language options, clone status config
- utils/format.ts: genderLabel, languageLabel, genderClass, formatTime, formatFileSize
- utils/audio.ts: getAudioDuration
- test/pages/voices/smoke.test.tsx: smoke test for vitest related mode

Main file reduced from 1783 to 1647 lines.
Functionally equivalent, no behavior changes.

Signed-off-by: xiaoxia <xiaoxia@xiaoxiajianji.com>
xiaoxia force-pushed refactor/voice-library-phase1 from 00ff978352 to ae78918ae4 2026-07-25 12:15:01 +08:00 Compare
xiaoxia closed this pull request 2026-07-25 12:25:25 +08:00
auto-approve-bot commented 2026-07-25 12:26:09 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #873

⚠️ 问题（1个需要修改）

  1. Diff 内容截断：提供的 diff 仅包含 pnpm-lock.yaml 的部分内容，且已被截断。PR 修改列表中的核心业务文件（如 VoiceLibrary.tsx, audio.ts, types.ts 等）的代码变更未显示。由于缺少源码变更，无法对本次重构的逻辑正确性、安全隐患及性能问题进行有效审查。

💡 建议（0个可选）

无

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能

🤖 由 AI 代码审查机器人自动生成 | 2026-07-25 04:26:09 | 模型:

## 代码审查结果 - PR #873 ### ⚠️ 问题（1个需要修改） 1. **Diff 内容截断**：提供的 diff 仅包含 `pnpm-lock.yaml` 的部分内容，且已被截断。PR 修改列表中的核心业务文件（如 `VoiceLibrary.tsx`, `audio.ts`, `types.ts` 等）的代码变更未显示。由于缺少源码变更，无法对本次重构的逻辑正确性、安全隐患及性能问题进行有效审查。 ### 💡 建议（0个可选） 无 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-25 04:26:09 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-07-25 12:28:02 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #873 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #873 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 35s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m15s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m1s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 54s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m1s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m50s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 25s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m23s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 43s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 4m28s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m42s
Details
AI Code Review / AI Code Review (pull_request) Successful in 5m3s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 4m56s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 5m58s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 16s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Failing after 16s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m46s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#873
Delete Branch "refactor/voice-library-phase1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?