xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 10 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

refactor(assets): Phase 1 - extract types, constants and utils #892

Merged
auto-approve-bot merged 3 commits from refactor/asset-library-phase1 into develop 2026-07-25 17:18:27 +08:00
Conversation 3 Commits 3 Files Changed 6
+267 -178
xiaoxia commented 2026-07-25 16:22:54 +08:00
Owner
Copy Link
Copy Source

AssetLibrary 重构 Phase 1

背景

AssetLibrary.tsx (1279行) 三阶段渐进式重构的第一步，抽离类型、常量和工具函数。

变更内容

**新增文件 (5个):

  • apps/web/src/pages/assets/types.ts — 类型定义与数据映射
    • AssetKind, StatusType, LibraryItem, AssetItem
    • inferKind, inferStatus, mapLibrary, mapAsset
  • apps/web/src/pages/assets/constants.ts — 常量配置
    • 文件大小限制、筛选选项、分类配置、状态配置
  • apps/web/src/pages/assets/utils/format.ts — 格式化工具
    • formatDuration, formatFileSize, formatDate
  • apps/web/src/pages/assets/utils/asset.ts — 素材工具函数
    • kindLabel, thumbGradient
  • apps/web/src/test/pages/assets/smoke.test.tsx — smoke test

修改文件:

  • apps/web/src/pages/assets/AssetLibrary.tsx — 移除已抽离的代码，改为 import 新模块

数据

  • 主文件行数: 1279 → 1124 行（-155行，-12.1%）

验收

  • pnpm lint 通过
  • pnpm tsc --noEmit 通过
  • pnpm test run related 通过
  • 功能等价，无行为变化
  • 0 any、0 ts-ignore、0 eslint-disable
  • import 路径统一使用 @/pages/assets/xxx

参考

对齐 VoiceLibrary 和 VoiceMaterialLibrary 的 Phase 1 重构模式。

## AssetLibrary 重构 Phase 1 ### 背景 AssetLibrary.tsx (1279行) 三阶段渐进式重构的第一步，抽离类型、常量和工具函数。 ### 变更内容 **新增文件 (5个): - `apps/web/src/pages/assets/types.ts` — 类型定义与数据映射 - `AssetKind`, `StatusType`, `LibraryItem`, `AssetItem` - `inferKind`, `inferStatus`, `mapLibrary`, `mapAsset` - `apps/web/src/pages/assets/constants.ts` — 常量配置 - 文件大小限制、筛选选项、分类配置、状态配置 - `apps/web/src/pages/assets/utils/format.ts` — 格式化工具 - `formatDuration`, `formatFileSize`, `formatDate` - `apps/web/src/pages/assets/utils/asset.ts` — 素材工具函数 - `kindLabel`, `thumbGradient` - `apps/web/src/test/pages/assets/smoke.test.tsx` — smoke test **修改文件:** - `apps/web/src/pages/assets/AssetLibrary.tsx` — 移除已抽离的代码，改为 import 新模块 ### 数据 - 主文件行数: 1279 → 1124 行（-155行，-12.1%） ### 验收 - [ ] `pnpm lint` 通过 - [ ] `pnpm tsc --noEmit` 通过 - [ ] `pnpm test run related` 通过 - [x] 功能等价，无行为变化 - [x] 0 any、0 ts-ignore、0 eslint-disable - [x] import 路径统一使用 `@/pages/assets/xxx` ### 参考 对齐 VoiceLibrary 和 VoiceMaterialLibrary 的 Phase 1 重构模式。
xiaoxia added 1 commit 2026-07-25 16:22:54 +08:00
refactor(assets): Phase 1 - extract types, constants and utils
AI Code Review / AI Code Review (pull_request) Failing after 0s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 18s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 43s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 47s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 16s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 44s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 1m59s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 1m56s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 42s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 15s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 40s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m27s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 16s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
17c125f8a5 
Extract types, constants, and utility functions from AssetLibrary.tsx
into separate modules, following the VoiceLibrary / VoiceMaterialLibrary
refactoring pattern:

- types.ts: AssetKind, StatusType, LibraryItem, AssetItem interfaces
  and mapping functions (mapLibrary, mapAsset, inferKind, inferStatus)
- constants.ts: file size limits, filter options, category configs
- utils/format.ts: formatDuration, formatFileSize, formatDate
- utils/asset.ts: kindLabel, thumbGradient

Also adds smoke test for vitest related mode coverage.

Main file: 1279 → 1124 lines (-155)
xiaoxia added 1 commit 2026-07-25 17:03:52 +08:00
fix(assets): remove unused LibraryItem import
AI Code Review / AI Code Review (pull_request) Failing after 0s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 4s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 47s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 30s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 46s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Has been cancelled
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been cancelled
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been cancelled
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
Preview Deploy / Deploy Preview Environment (pull_request) Has been cancelled
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 41s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 41s
Details
c91e37eaa3
xiaoxia added 1 commit 2026-07-25 17:12:27 +08:00
fix(assets): lint errors for Phase 1
AI Code Review / AI Code Review (pull_request) Failing after 0s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 5s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 50s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 49s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 42s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m7s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 15s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m5s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 45s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 12s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m50s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 15s
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m36s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Failing after 14s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 20s
Details
9dad7c333e
auto-approve-bot approved these changes 2026-07-25 17:17:06 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-25 17:17:06 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot merged commit 32868e54ad into develop 2026-07-25 17:18:27 +08:00
auto-approve-bot deleted branch refactor/asset-library-phase1 2026-07-25 17:18:28 +08:00
gitea-actions bot commented 2026-07-25 17:18:47 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #892 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #892 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#892
Delete Branch "refactor/asset-library-phase1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?