xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 3 Actions 3 Packages Projects Releases 7 Wiki Activity

fix(test): 修复Unit Tests收集失败 - dedup模块级mock污染sys.modules #917

Merged
xiaoxia merged 1 commits from fix/ci-unit-tests-collection-906 into develop 2026-07-26 09:29:39 +08:00
Conversation 1 Commits 1 Files Changed 1
+35 -41
xiaoxia commented 2026-07-26 09:08:18 +08:00
Owner
Copy Link
Copy Source

问题

Unit Tests收集阶段5个文件报错：3个AttributeError: spec + 2个ImportError: cannot import name assert_auto_create_schema_allowed

根因

test_dedup_pure.py 在模块级 mock 了整个 worker_app 包和 packages.adapters.sqlalchemy_impl 包，污染全局 sys.modules。pytest 按字母顺序收集测试时，dedup_pure（d开头）先被收集，它的模块级 mock 导致后续测试文件导入这些包的子模块时失败。

修复

  • 只 mock 具体叶子模块（worker_app.db / worker_app.celery_app / worker_app.core.config），不 mock 整个 worker_app 包
  • 只 mock packages.adapters.sqlalchemy_impl.session（真正触发数据库连接的元凶），不 mock 整个 sqlalchemy_impl 包
  • 去掉不必要的 schema_guard mock（dedup 不导入它）
  • 所有 mock 模块加 __spec__=None，避免 Python 导入系统 AttributeError

验证

  • 本地全量收集：6942 tests collected，0 errors
  • dedup_pure 自身测试：20 passed
  • 之前失败的5个文件：102 passed

fix #906

## 问题 Unit Tests收集阶段5个文件报错：3个AttributeError: __spec__ + 2个ImportError: cannot import name assert_auto_create_schema_allowed ## 根因 `test_dedup_pure.py` 在模块级 mock 了整个 `worker_app` 包和 `packages.adapters.sqlalchemy_impl` 包，污染全局 `sys.modules`。pytest 按字母顺序收集测试时，dedup_pure（d开头）先被收集，它的模块级 mock 导致后续测试文件导入这些包的子模块时失败。 ## 修复 - 只 mock 具体叶子模块（worker_app.db / worker_app.celery_app / worker_app.core.config），不 mock 整个 worker_app 包 - 只 mock `packages.adapters.sqlalchemy_impl.session`（真正触发数据库连接的元凶），不 mock 整个 sqlalchemy_impl 包 - 去掉不必要的 schema_guard mock（dedup 不导入它） - 所有 mock 模块加 `__spec__=None`，避免 Python 导入系统 AttributeError ## 验证 - 本地全量收集：6942 tests collected，0 errors - dedup_pure 自身测试：20 passed - 之前失败的5个文件：102 passed fix #906
xiaoxia added 1 commit 2026-07-26 09:17:55 +08:00
fix(test): fix Unit Tests collection failure - dedup mock pollutes sys.modules
AI Code Review / AI Code Review (pull_request) Failing after 0s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 39s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m11s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m24s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 56s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 2m7s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 2m54s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m21s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 36s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 4m15s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 5m45s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m19s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m13s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 20s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Failing after 23s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 51m3s
Details
24b4c6f1a0
xiaoxia force-pushed fix/ci-unit-tests-collection-906 from 50b6126367 to 24b4c6f1a0 2026-07-26 09:17:55 +08:00 Compare
xiaoxia merged commit 56ab6bcef4 into develop 2026-07-26 09:29:39 +08:00
gitea-actions bot commented 2026-07-26 09:29:58 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #917 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #917 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#917
Delete Branch "fix/ci-unit-tests-collection-906"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?