xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 9 Pull Requests 3 Actions 6 Packages Projects Releases 7 Wiki Activity

fix(ci): #916 improve check-frontend-only: pagination + infra detection + fix empty-line bug #926

Merged
xiaoxia merged 4 commits from fix/ci-required-checks-coverage-916 into develop 2026-07-26 15:19:30 +08:00
Conversation 2 Commits 4 Files Changed 1
+41 -9
xiaoxia commented 2026-07-26 13:06:47 +08:00
Owner
Copy Link
Copy Source

调查结论

实际required check覆盖率远高于工单描述：8/9 的 required check 是始终运行的，只有 1 个测试类 check 是条件触发的（Unit Tests 或 Frontend Unit Tests）。

原因为 check-frontend-only 的判定逻辑存在 空行计数 bug（grep -cv 会把末尾空行算进去），导致 BACKEND_COUNT 永远 >= 1，纯前端/纯后端的判定实际上从未生效，所有 PR 都是全量 CI。

修复内容

1. 修复空行计数 bug

  • 原逻辑：grep -cv "^apps/web/" 会把末尾空行算作后端文件
  • 新逻辑：BACKEND_COUNT = TOTAL - FRONTEND_COUNT，其中 TOTAL 是非空行数

2. 修复大 PR 漏判风险

  • 原逻辑：只取前 300 个文件，超大 PR 可能漏判
  • 新逻辑：分页获取所有变更文件，确保完整判定

3. 新增基础设施文件强制全量检测

  • 改了 infra/、Dockerfile、.gitea/workflows/、scripts/ci/、docker/ 的 PR，强制运行完整 CI
  • 防止 CI 配置或 Dockerfile 变更时，相关构建/检查被意外跳过

关 #916

## 调查结论 实际required check覆盖率远高于工单描述：**8/9 的 required check 是始终运行的**，只有 1 个测试类 check 是条件触发的（Unit Tests 或 Frontend Unit Tests）。 原因为 check-frontend-only 的判定逻辑存在 **空行计数 bug**（grep -cv 会把末尾空行算进去），导致 `BACKEND_COUNT` 永远 >= 1，纯前端/纯后端的判定实际上从未生效，所有 PR 都是全量 CI。 ## 修复内容 ### 1. 修复空行计数 bug - 原逻辑：`grep -cv "^apps/web/"` 会把末尾空行算作后端文件 - 新逻辑：`BACKEND_COUNT = TOTAL - FRONTEND_COUNT`，其中 TOTAL 是非空行数 ### 2. 修复大 PR 漏判风险 - 原逻辑：只取前 300 个文件，超大 PR 可能漏判 - 新逻辑：分页获取所有变更文件，确保完整判定 ### 3. 新增基础设施文件强制全量检测 - 改了 `infra/`、`Dockerfile`、`.gitea/workflows/`、`scripts/ci/`、`docker/` 的 PR，强制运行完整 CI - 防止 CI 配置或 Dockerfile 变更时，相关构建/检查被意外跳过 关 #916
xiaoxia added 1 commit 2026-07-26 13:06:47 +08:00
fix(ci): #916 improve check-frontend-only: pagination + infra detection + fix empty-line bug
AI Code Review / AI Code Review (pull_request) Failing after 0s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 21s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m57s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 47m18s
Details
70022bed89
xiaoxia added 1 commit 2026-07-26 13:15:47 +08:00
Merge branch 'develop' of https://git.xiaoxiajianji.com/xiaoxia/xiaoxia-saas into fix/ci-required-checks-coverage-916
AI Code Review / AI Code Review (pull_request) Failing after 0s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 37s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m47s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 47m21s
Details
5b562fe475
gitea-actions bot commented 2026-07-26 13:25:23 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #926
预览链接 https://pr-926.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #926 | | 预览链接 | [https://pr-926.preview.xiaoxiajianji.com](https://pr-926.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia added 1 commit 2026-07-26 14:09:22 +08:00
fix(ci): #916 fix YAML syntax error in check-frontend-only step
AI Code Review / AI Code Review (pull_request) Failing after 0s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Failing after 17s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 49s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 32s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 8s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m9s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m20s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 43s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 28s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m47s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 3m40s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m4s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 5m36s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m40s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 47m34s
Details
9705f4f449 
The multi-line string concatenation had zero-indent closing quote which
broke YAML parsing. Replace with $'\n' single-line concatenation.
xiaoxia added 1 commit 2026-07-26 15:00:07 +08:00
fix(ci): #916 fix set -e crash in pagination loop
AI Code Review / AI Code Review (pull_request) Failing after 0s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 19s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 28s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 8s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m0s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m28s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m35s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 53s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Successful in 29s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m39s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Successful in 4m8s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m11s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m37s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 5m25s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Failing after 14s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 18s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 49m20s
Details
ba481f8ca7 
Python sys.exit(1) caused command substitution to fail under set -e.
Replace exit-code-based pagination with wc -l line count check,
and add || true guard to prevent early exit.
xiaoxia force-pushed fix/ci-required-checks-coverage-916 from e7ae642ec5 to ba481f8ca7 2026-07-26 15:00:07 +08:00 Compare
xiaoxia merged commit 6a303a3b6e into develop 2026-07-26 15:19:30 +08:00
xiaoxia deleted branch fix/ci-required-checks-coverage-916 2026-07-26 15:19:30 +08:00
gitea-actions bot commented 2026-07-26 15:22:27 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #926 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #926 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#926
Delete Branch "fix/ci-required-checks-coverage-916"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?