xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions 1 Packages Projects Releases 7 Wiki Activity

refactor(voice-clone): API层按模块拆分（208行→入口28行, -87%） #944

Closed
xiaoxia wants to merge 2 commits from refactor/voice-clone-api into develop
pull from: refactor/voice-clone-api
merge into: xiaoxia:develop
Conversation 6 Commits 2 Files Changed 5
+241 -208
xiaoxia commented 2026-07-26 16:56:54 +08:00
Owner
Copy Link
Copy Source

voice-clone.ts 拆分为目录结构，4个文件：types / utils / clones / index。导入路径保持向后兼容。

voice-clone.ts 拆分为目录结构，4个文件：types / utils / clones / index。导入路径保持向后兼容。
xiaoxia added 1 commit 2026-07-26 16:56:55 +08:00
refactor(voice-clone): API层按模块拆分（208行→入口28行, -87%）
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 13s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 27s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m4s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 59s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 32s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m33s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m7s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m38s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m12s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 25s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 42s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 3m14s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 26s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
01ca228c07 
将 voice-clone.ts 单文件拆分为目录结构：
- types.ts — 类型定义
- utils.ts — toVoiceClone 映射 + formatDuration
- clones.ts — 克隆 CRUD + 状态 + 重试
- index.ts — 统一入口 re-export

导入路径 @/api/voice-clone 保持向后兼容。
xiaoxia added 1 commit 2026-07-27 12:35:01 +08:00
Merge branch 'develop' into refactor/voice-clone-api
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 7s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m12s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m45s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m21s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 43s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 24s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m4s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m42s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m39s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 42s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m39s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 15m19s
Details
CI/CD Pipeline / CI Gate (pull_request) 失败: CI/CD Pipeline / Validate - Code Quality (pull_request) [frontend-only]
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 22s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 10s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
3562b33ad0
auto-approve-bot approved these changes 2026-07-27 14:32:55 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-27 14:32:55 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot commented 2026-07-27 14:33:21 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #944

⚠️ 问题（0个需要修改）

无

💡 建议（2个可选）

  1. apps/web/src/api/voice-clone/utils.ts 第18-24行：toVoiceClone 函数中 duration_seconds 和 progress 字段被硬编码为 0。虽然这是从旧代码迁移过来的，但根据注释“任务 3.15：新增 progress 字段”，建议补充实际的数据映射逻辑，例如从 profile.metadata_?.duration 获取时长。
  2. apps/web/src/api/voice-clone/clones.ts 第57-65行：updateVoiceClone 函数目前是 Stub 实现，仅在前端模拟更新数据，并未真正调用后端 PATCH 接口。虽然注释说明了原因，但容易误导调用者。建议确保调用方知晓此限制，或在函数名中添加 mock/local 前缀以示区分。

✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好

🤖 由 AI 代码审查机器人自动生成 | 2026-07-27 06:33:21 | 模型:

## 代码审查结果 - PR #944 ### ⚠️ 问题（0个需要修改） 无 ### 💡 建议（2个可选） 1. **apps/web/src/api/voice-clone/utils.ts 第18-24行**：`toVoiceClone` 函数中 `duration_seconds` 和 `progress` 字段被硬编码为 `0`。虽然这是从旧代码迁移过来的，但根据注释“任务 3.15：新增 progress 字段”，建议补充实际的数据映射逻辑，例如从 `profile.metadata_?.duration` 获取时长。 2. **apps/web/src/api/voice-clone/clones.ts 第57-65行**：`updateVoiceClone` 函数目前是 Stub 实现，仅在前端模拟更新数据，并未真正调用后端 PATCH 接口。虽然注释说明了原因，但容易误导调用者。建议确保调用方知晓此限制，或在函数名中添加 `mock`/`local` 前缀以示区分。 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-27 06:33:21 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-07-27 14:33:37 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #944
预览链接 https://pr-944.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #944 | | 预览链接 | [https://pr-944.preview.xiaoxiajianji.com](https://pr-944.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-07-27 14:47:55 +08:00
Collaborator
Copy Link
Copy Source

Auto merge skipped after multiple 405 errors: PR may have conflicts or unresolved checks. Please review manually. This is not a CI failure.

Auto merge skipped after multiple 405 errors: PR may have conflicts or unresolved checks. Please review manually. This is not a CI failure.
xiaoxia closed this pull request 2026-07-27 16:35:18 +08:00
gitea-actions bot commented 2026-07-27 18:16:07 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #944 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #944 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 7s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m12s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m45s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m21s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 43s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 24s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m4s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m42s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m39s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 42s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m39s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 15m19s
Details
CI/CD Pipeline / CI Gate (pull_request) 失败: CI/CD Pipeline / Validate - Code Quality (pull_request) [frontend-only]
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 22s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 10s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#944
Delete Branch "refactor/voice-clone-api"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?