xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

test(wave95): 82 unit tests for domain entities #958

Closed
xiaoxia wants to merge 0 commits from test/wave95-domain-entities into develop
pull from: test/wave95-domain-entities
merge into: xiaoxia:develop
Conversation 3 Commits - Files Changed -
xiaoxia commented 2026-07-26 17:33:12 +08:00
Owner
Copy Link
Copy Source

变更内容

  • 新增 82 个单元测试，完整覆盖 domain/entities.py 所有业务逻辑
  • 覆盖 Project / AssetLibrary / AssetStatus / Asset / IngestJob / User 6 个实体

测试分布

  • Project (13 tests): create 校验 + 名称清理 + 权限判断（is_owner / is_shared_with / can_access）
  • AssetLibrary (6 tests): create 校验 + 3 种素材库类型
  • AssetStatus (26 tests): 枚举值 + missing 向后兼容（uploaded/success/fail/err 等 20+ 别名映射）
  • Asset (23 tests): create 校验 + file_type 属性 + 标签增删去重幂等
  • IngestJob (11 tests): create 校验 + 字段 strip
  • User (3 tests): 默认值 + 管理员 + 订阅

测试结果

本地 82 passed

## 变更内容 - 新增 82 个单元测试，完整覆盖 domain/entities.py 所有业务逻辑 - 覆盖 Project / AssetLibrary / AssetStatus / Asset / IngestJob / User 6 个实体 ## 测试分布 - **Project (13 tests)**: create 校验 + 名称清理 + 权限判断（is_owner / is_shared_with / can_access） - **AssetLibrary (6 tests)**: create 校验 + 3 种素材库类型 - **AssetStatus (26 tests)**: 枚举值 + _missing_ 向后兼容（uploaded/success/fail/err 等 20+ 别名映射） - **Asset (23 tests)**: create 校验 + file_type 属性 + 标签增删去重幂等 - **IngestJob (11 tests)**: create 校验 + 字段 strip - **User (3 tests)**: 默认值 + 管理员 + 订阅 ## 测试结果 本地 82 passed
xiaoxia force-pushed test/wave95-domain-entities from e31e9c2883 to 0482e62c59 2026-07-26 20:11:29 +08:00 Compare
gitea-actions bot commented 2026-07-26 20:16:00 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #958
预览链接 https://pr-958.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #958 | | 预览链接 | [https://pr-958.preview.xiaoxiajianji.com](https://pr-958.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-07-27 01:23:06 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #958

⚠️ 问题（2个需要修改）

  1. packages/domain/media_validation.py 第107行：丢失了非白名单视频编码的日志记录，导致可观测性下降。
    • 原代码在检测到非白名单编码时会记录 logger.info，便于排查问题。新代码虽然注释提到“调用方负责日志”，但实际调用方 ingest.py 只是调用了 _is_valid_media，并未进行额外的编解码器检查，导致该日志信息彻底丢失。
  2. packages/domain/media_validation.py 第75行：safe_parse_fps 函数未处理 NaN 和 Infinity 边界情况。
    • 当输入字符串为 "nan"、"inf" 等特殊值时，Python 的 float() 转换不会抛出 ValueError，而是返回 nan 或 inf。这会导致后续计算（如 duration * fps）产生错误结果或异常，而当前的 try-except 块无法捕获这种情况。

💡 建议（1个可选）

  1. packages/domain/media_validation.py 第93-105行：is_valid_media 函数对元数据值的类型转换缺乏容错性。
    • 代码直接使用 int() 和 float() 强转 metadata 中的值。如果上游 ffprobe 返回的数据格式异常（如字符串 "N/A"），会导致 ValueError 崩溃。建议增加类型检查或使用辅助函数进行安全转换，确保领域模块的健壮性。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能无明显问题

🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 17:23:06 | 模型:

## 代码审查结果 - PR #958 ### ⚠️ 问题（2个需要修改） 1. **packages/domain/media_validation.py 第107行**：丢失了非白名单视频编码的日志记录，导致可观测性下降。 - 原代码在检测到非白名单编码时会记录 `logger.info`，便于排查问题。新代码虽然注释提到“调用方负责日志”，但实际调用方 `ingest.py` 只是调用了 `_is_valid_media`，并未进行额外的编解码器检查，导致该日志信息彻底丢失。 2. **packages/domain/media_validation.py 第75行**：`safe_parse_fps` 函数未处理 `NaN` 和 `Infinity` 边界情况。 - 当输入字符串为 `"nan"`、`"inf"` 等特殊值时，Python 的 `float()` 转换不会抛出 `ValueError`，而是返回 `nan` 或 `inf`。这会导致后续计算（如 `duration * fps`）产生错误结果或异常，而当前的 `try-except` 块无法捕获这种情况。 ### 💡 建议（1个可选） 1. **packages/domain/media_validation.py 第93-105行**：`is_valid_media` 函数对元数据值的类型转换缺乏容错性。 - 代码直接使用 `int()` 和 `float()` 强转 `metadata` 中的值。如果上游 `ffprobe` 返回的数据格式异常（如字符串 `"N/A"`），会导致 `ValueError` 崩溃。建议增加类型检查或使用辅助函数进行安全转换，确保领域模块的健壮性。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能无明显问题 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 17:23:06 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia force-pushed test/wave95-domain-entities from d619204d87 to 5289e427e2 2026-07-27 18:57:12 +08:00 Compare
xiaoxia closed this pull request 2026-07-27 19:49:01 +08:00
gitea-actions bot commented 2026-07-27 21:00:04 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #958 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #958 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (push) Has been cancelled
Details
CI/CD Pipeline / Validate - Code Quality (push) Has been cancelled
Details
CI/CD Pipeline / Validate - Type Check (mypy) (push) Has been cancelled
Details
CI/CD Pipeline / Validate - Migration (alembic) (push) Has been cancelled
Details
CI/CD Pipeline / Unit Tests (push) Has been cancelled
Details
CI/CD Pipeline / Integration Tests (push) Has been cancelled
Details
CI/CD Pipeline / Frontend Lint (push) Has been cancelled
Details
CI/CD Pipeline / Frontend Unit Tests (push) Has been cancelled
Details
CI/CD Pipeline / PR Build API Image (push) Has been cancelled
Details
CI/CD Pipeline / PR Build Web Image (push) Has been cancelled
Details
CI/CD Pipeline / PR Build Worker Image (push) Has been cancelled
Details
CI/CD Pipeline / Build Staging API Image (push) Has been cancelled
Details
CI/CD Pipeline / Build Staging Web Image (push) Has been cancelled
Details
CI/CD Pipeline / Build Staging Worker Image (push) Has been cancelled
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (push) Has been cancelled
Details
CI/CD Pipeline / Staging E2E Tests (push) Has been cancelled
Details
CI/CD Pipeline / Staging API Integration Tests (push) Has been cancelled
Details
CI/CD Pipeline / Build Production API Image (push) Has been cancelled
Details
CI/CD Pipeline / Build Production Web Image (push) Has been cancelled
Details
CI/CD Pipeline / Build Production Worker Image (push) Has been cancelled
Details
CI/CD Pipeline / Deploy Production (push) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (push) Has been cancelled
Details
CI/CD Pipeline / ACR Image Cleanup (push) Has been cancelled
Details
CI/CD Pipeline / Canary Release to Production (push) Has been cancelled
Details
CI/CD Pipeline / CI Gate (push) Has been cancelled
Details
AI Code Review / AI Code Review (pull_request) Failing after 0s
Details
PR Automation / Auto Approve on CI Green (pull_request) Failing after 0s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Failing after 0s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Failing after 0s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m33s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 48s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Failing after 1s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 0s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Failing after 1s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Failing after 0s
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 0s
Details
CI/CD Pipeline / Integration Tests (pull_request) Failing after 0s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 0s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 0s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 10m44s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m58s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 1m54s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 0s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#958
Delete Branch "test/wave95-domain-entities"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?