xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 9 Pull Requests 2 Actions 4 Packages Projects Releases 7 Wiki Activity

refactor(task-history): 三阶段重构 TaskHistory（302→90行, -70%） #970

Closed
xiaoxia wants to merge 3 commits from refactor/task-history into develop
pull from: refactor/task-history
merge into: xiaoxia:develop
Conversation 5 Commits 3 Files Changed 6
+425 -258
xiaoxia commented 2026-07-26 18:10:55 +08:00
Owner
Copy Link
Copy Source

变更说明

TaskHistory 任务历史页三阶段重构，主文件 302→90 行（-70%）

Phase 1: 常量/工具

  • constants.ts: TaskStatus / statusLabel / TABS 配置 / PAGE_SIZE
  • utils.ts: normalizeStatus / formatDate

Phase 2: UI 组件

  • components/TaskList.tsx: HistoryTabs（Tab栏） + TaskItem（任务卡片） + Pagination（分页）
  • components/States.tsx: PageHeader / LoadingState / ErrorState / EmptyState

Phase 3: 业务 Hook

  • hooks/useTaskHistory.ts: 列表查询 + 筛选 + 分页 + 重试 + 数据映射

说明

  • 页面功能完全不变，纯结构重构
  • Tab 计数、分页、重试逻辑全部封装进 Hook，组件纯展示
## 变更说明 TaskHistory 任务历史页三阶段重构，主文件 302→90 行（-70%） ### Phase 1: 常量/工具 - `constants.ts`: TaskStatus / statusLabel / TABS 配置 / PAGE_SIZE - `utils.ts`: normalizeStatus / formatDate ### Phase 2: UI 组件 - `components/TaskList.tsx`: HistoryTabs（Tab栏） + TaskItem（任务卡片） + Pagination（分页） - `components/States.tsx`: PageHeader / LoadingState / ErrorState / EmptyState ### Phase 3: 业务 Hook - `hooks/useTaskHistory.ts`: 列表查询 + 筛选 + 分页 + 重试 + 数据映射 ### 说明 - 页面功能完全不变，纯结构重构 - Tab 计数、分页、重试逻辑全部封装进 Hook，组件纯展示
xiaoxia added 1 commit 2026-07-26 18:10:55 +08:00
refactor(task-history): 三阶段重构 TaskHistory（302→90行, -70%）
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 36s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 38s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m18s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m23s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 40s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 3m6s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m18s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m10s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 41s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m7s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m45s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 7m18s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 29s
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
203f001c1d 
- Phase 1: 抽 constants（TaskStatus/TABS/PAGE_SIZE）+ utils（normalizeStatus/formatDate）
- Phase 2: 抽 2 个 UI 组件（TaskList含HistoryTabs/TaskItem/Pagination + States含4种状态组件）
- Phase 3: 抽 useTaskHistory 业务 Hook（查询/筛选/分页/重试）
- 主文件 302→90 行，职责分离清晰
xiaoxia added 1 commit 2026-07-27 12:34:44 +08:00
Merge branch 'develop' into refactor/task-history
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 19s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 58s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m35s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m40s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 37s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 3m1s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m15s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m26s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 44s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m44s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m47s
Details
AI Code Review / AI Code Review (pull_request) Successful in 4m31s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been cancelled
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been cancelled
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
f8f6082cbd
xiaoxia added 1 commit 2026-07-27 15:27:07 +08:00
fix: MappedTask.template 改为可选类型
CI/CD Pipeline / CI Gate (pull_request) CI运行中 [frontend-only]
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 22s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m21s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m42s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m45s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 30s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 3m6s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m16s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m38s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 52s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m25s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m26s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 3m17s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 19s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 10s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
fc4997874a
auto-approve-bot approved these changes 2026-07-27 17:00:41 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-27 17:00:41 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot commented 2026-07-27 17:00:51 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #970

⚠️ 问题（1个需要修改）

  1. hooks/useTaskHistory.ts & components/TaskList.tsx：全局重试状态导致所有重试按钮误触禁用
    • 问题描述：useTaskHistory 返回的 retryLoading 是基于 retryMutation.isPending 的全局布尔值。当用户点击列表中某一个任务的“重试”按钮时，该状态变为 true，导致列表中所有失败任务的“重试”按钮同时显示“重试中...”并被禁用。这阻止了用户连续重试多个失败任务，且对未被重试的任务提供了错误的 UI 反馈。
    • 修改建议：应在 Hook 中维护一个正在重试的任务 ID（例如 Set<string> 或 string | null），或者将 retryMutation 对象传递给子组件，让子组件根据 task.id 判断当前任务是否处于 loading 状态。

💡 建议（2个可选）

  1. components/TaskList.tsx 第115行：分页组件未做页码省略处理，存在性能和 UI 隐患
    • 具体内容：代码使用 Array.from({ length: totalPages }) 渲染所有页码按钮。如果 totalPages 很大（例如超过 20 或 100），会导致页面渲染大量 DOM 节点，严重影响性能并破坏 UI 布局。建议实现标准的省略号分页逻辑（如 1 ... 4 5 6 ... 10）。
  2. hooks/useTaskHistory.ts 第85行：paginatedTasks 计算未使用 useMemo 包裹
    • 具体内容：paginatedTasks 在 Hook 每次执行时都会重新计算并创建一个新的数组引用。虽然 slice 操作很快，但新的引用会导致下游 TaskList 组件在每次父组件渲染时都触发重渲染（即使数据未变）。建议使用 useMemo 缓存计算结果，依赖项为 [filteredTasks, currentPage]。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能

🤖 由 AI 代码审查机器人自动生成 | 2026-07-27 09:00:51 | 模型:

## 代码审查结果 - PR #970 ### ⚠️ 问题（1个需要修改） 1. **hooks/useTaskHistory.ts & components/TaskList.tsx**：全局重试状态导致所有重试按钮误触禁用 - **问题描述**：`useTaskHistory` 返回的 `retryLoading` 是基于 `retryMutation.isPending` 的全局布尔值。当用户点击列表中某一个任务的“重试”按钮时，该状态变为 `true`，导致列表中**所有**失败任务的“重试”按钮同时显示“重试中...”并被禁用。这阻止了用户连续重试多个失败任务，且对未被重试的任务提供了错误的 UI 反馈。 - **修改建议**：应在 Hook 中维护一个正在重试的任务 ID（例如 `Set<string>` 或 `string | null`），或者将 `retryMutation` 对象传递给子组件，让子组件根据 `task.id` 判断当前任务是否处于 loading 状态。 ### 💡 建议（2个可选） 1. **components/TaskList.tsx 第115行**：分页组件未做页码省略处理，存在性能和 UI 隐患 - **具体内容**：代码使用 `Array.from({ length: totalPages })` 渲染所有页码按钮。如果 `totalPages` 很大（例如超过 20 或 100），会导致页面渲染大量 DOM 节点，严重影响性能并破坏 UI 布局。建议实现标准的省略号分页逻辑（如 `1 ... 4 5 6 ... 10`）。 2. **hooks/useTaskHistory.ts 第85行**：`paginatedTasks` 计算未使用 `useMemo` 包裹 - **具体内容**：`paginatedTasks` 在 Hook 每次执行时都会重新计算并创建一个新的数组引用。虽然 `slice` 操作很快，但新的引用会导致下游 `TaskList` 组件在每次父组件渲染时都触发重渲染（即使数据未变）。建议使用 `useMemo` 缓存计算结果，依赖项为 `[filteredTasks, currentPage]`。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ⚠️ 建议关注性能 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-27 09:00:51 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
gitea-actions bot commented 2026-07-27 17:02:03 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #970
预览链接 https://pr-970.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #970 | | 预览链接 | [https://pr-970.preview.xiaoxiajianji.com](https://pr-970.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia closed this pull request 2026-07-27 17:02:29 +08:00
gitea-actions bot commented 2026-07-27 18:18:31 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #970 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #970 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / CI Gate (pull_request) CI运行中 [frontend-only]
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 22s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m21s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m42s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m45s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 30s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 3m6s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m16s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m38s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 52s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m25s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m26s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 3m17s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 19s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 10s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#970
Delete Branch "refactor/task-history"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?