xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases 7 Wiki Activity

refactor(wave110): 抽离pip_config领域模型 + 64单测 #995

Closed
xiaoxia wants to merge 1 commits from test/wave110-pip-config into develop
pull from: test/wave110-pip-config
merge into: xiaoxia:develop
Conversation 3 Commits 1 Files Changed 3
+793 -191
xiaoxia commented 2026-07-27 00:52:31 +08:00
Owner
Copy Link
Copy Source

变更内容

  • 新建 packages/domain/pip_config.py：纯逻辑领域模型

    • PiPLayerConfig / PiPConfig 数据类（含 validate / from_dict）
    • parse_size_value / calculate_pip_position 纯逻辑函数
    • 9 个位置常量 + 6 个动画常量

  • 精简 apps/worker/video_processing/pip_engine.py

    • 509→357行（-152行，-30%）
    • 数据类/常量/解析逻辑全部委托给 pip_config
    • 保留模块级导出与类方法薄包装，完全向后兼容

  • 新增 64 个单测（test_pip_config.py）

    • PiPLayerConfig 默认值 + validate（20 个）
    • PiPConfig.from_dict + 属性（13 个）
    • parse_size_value 各种输入（14 个）
    • calculate_pip_position 9宫格 + custom + 边界（17 个）

验证

  • 本地全绿：90 passed（26 pip_engine 原有 + 64 新增）
  • black 格式化通过

关联

后端单测覆盖率提升 wave110，pip_engine 大文件拆分第一波。

## 变更内容 - **新建** `packages/domain/pip_config.py`：纯逻辑领域模型 - `PiPLayerConfig` / `PiPConfig` 数据类（含 validate / from_dict） - `parse_size_value` / `calculate_pip_position` 纯逻辑函数 - 9 个位置常量 + 6 个动画常量 - **精简** `apps/worker/video_processing/pip_engine.py` - 509→357行（-152行，-30%） - 数据类/常量/解析逻辑全部委托给 pip_config - 保留模块级导出与类方法薄包装，**完全向后兼容** - **新增** 64 个单测（test_pip_config.py） - PiPLayerConfig 默认值 + validate（20 个） - PiPConfig.from_dict + 属性（13 个） - parse_size_value 各种输入（14 个） - calculate_pip_position 9宫格 + custom + 边界（17 个） ## 验证 - 本地全绿：90 passed（26 pip_engine 原有 + 64 新增） - black 格式化通过 ## 关联 后端单测覆盖率提升 wave110，pip_engine 大文件拆分第一波。
xiaoxia added 1 commit 2026-07-27 00:52:31 +08:00
refactor(wave110): 抽离pip_config领域模型 + 64单测
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 12s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m6s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m3s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 33s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 20s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m0s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 54s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m0s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 57s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m36s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m24s
Details
AI Code Review / AI Code Review (pull_request) Successful in 4m28s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 3m37s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m32s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 35s
Details
cedb3ff8a4 
- 新建 packages/domain/pip_config.py：PiPLayerConfig/PiPConfig 数据类 +
  parse_size_value/calculate_pip_position 纯逻辑函数 + 9位置+6动画常量
- pip_engine.py: 509→357行 (-152行, -30%)，复用 pip_config 的类和函数
  保留模块级导出与类方法薄包装，完全向后兼容
- 新增 64 个单测覆盖数据模型 + 纯逻辑函数
gitea-actions bot commented 2026-07-27 01:42:26 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #995
预览链接 https://pr-995.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #995 | | 预览链接 | [https://pr-995.preview.xiaoxiajianji.com](https://pr-995.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-07-27 01:45:42 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #995

⚠️ 问题（0个需要修改）

无

💡 建议（1个可选）

  1. packages/domain/pip_config.py 第127行：建议在 PiPLayerConfig.validate 方法中增加对 margin 字段的非负校验。
    • 原因：当前代码校验了 corner_radius、start_time 等字段的非负性，但遗漏了 margin。虽然 calculate_pip_position 能处理负数（导致 PiP 偏移甚至移出画布），但通常业务逻辑中边距应为非负数。显式校验能尽早发现配置错误，避免产生不符合预期的画面布局。

✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好

🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 17:45:42 | 模型:

## 代码审查结果 - PR #995 ### ⚠️ 问题（0个需要修改） 无 ### 💡 建议（1个可选） 1. **packages/domain/pip_config.py 第127行**：建议在 `PiPLayerConfig.validate` 方法中增加对 `margin` 字段的非负校验。 - **原因**：当前代码校验了 `corner_radius`、`start_time` 等字段的非负性，但遗漏了 `margin`。虽然 `calculate_pip_position` 能处理负数（导致 PiP 偏移甚至移出画布），但通常业务逻辑中边距应为非负数。显式校验能尽早发现配置错误，避免产生不符合预期的画面布局。 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 17:45:42 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia closed this pull request 2026-07-27 15:26:20 +08:00
gitea-actions bot commented 2026-07-27 16:56:23 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #995 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #995 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 12s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m6s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m3s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 33s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 20s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m0s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 54s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m0s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 57s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m36s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m24s
Details
AI Code Review / AI Code Review (pull_request) Successful in 4m28s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 3m37s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m32s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 35s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#995
Delete Branch "test/wave110-pip-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?