xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 3 Actions 1 Packages Projects Releases 7 Wiki Activity

refactor(voice): 拆分 UploadVoiceModal，抽离5个子组件 #996

Closed
xiaoxia wants to merge 4 commits from refactor/upload-voice-modal-split into develop
pull from: refactor/upload-voice-modal-split
merge into: xiaoxia:develop
Conversation 5 Commits 4 Files Changed 6
+395 -266
xiaoxia commented 2026-07-27 00:53:29 +08:00
Owner
Copy Link
Copy Source

变更内容

UploadVoiceModal 单文件拆分，按功能模块抽离子组件：

新增组件（upload-voice/ 目录）

  • UploadDragger (58行): 拖拽上传区
  • SelectedFileInfo (45行): 已选文件信息展示
  • UploadProgress (48行): 上传进度条
  • UploadFormFields (114行): 表单区域（名称/性别/描述）
  • UploadActions (82行): 底部操作按钮（取消/上传）+ 前置校验

缩减情况

  • 主文件：329 → 112 行（-66%）
  • 仅保留 Modal 壳与状态组装

验证

  • 纯重构，无逻辑变更

自动生成 PR

## 变更内容 UploadVoiceModal 单文件拆分，按功能模块抽离子组件： ### 新增组件（upload-voice/ 目录） - **UploadDragger** (58行): 拖拽上传区 - **SelectedFileInfo** (45行): 已选文件信息展示 - **UploadProgress** (48行): 上传进度条 - **UploadFormFields** (114行): 表单区域（名称/性别/描述） - **UploadActions** (82行): 底部操作按钮（取消/上传）+ 前置校验 ### 缩减情况 - 主文件：329 → 112 行（-66%） - 仅保留 Modal 壳与状态组装 ### 验证 - 纯重构，无逻辑变更 --- _自动生成 PR_
xiaoxia added 1 commit 2026-07-27 00:53:30 +08:00
refactor(voice): 拆分 UploadVoiceModal，抽离 5 个子组件
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 29s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 52s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 58s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m26s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 31s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 25s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 56s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 44s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Failing after 35s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 2m21s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 2m9s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m43s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 24s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
35dd478f1d 
- UploadDragger: 拖拽上传区
- SelectedFileInfo: 已选文件信息
- UploadProgress: 上传进度条
- UploadFormFields: 表单区域（名称/性别/描述）
- UploadActions: 底部操作按钮（取消/上传）
- 主文件 329→112 行 (-66%)，仅保留 Modal 壳与状态组装
xiaoxia added 1 commit 2026-07-27 12:34:31 +08:00
Merge branch 'develop' into refactor/upload-voice-modal-split
CI/CD Pipeline / Check if frontend-only change (pull_request) Has been cancelled
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Has been cancelled
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Has been cancelled
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Has been cancelled
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Frontend Lint (pull_request) Has been cancelled
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / PR Build API Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been cancelled
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been cancelled
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
AI Code Review / AI Code Review (pull_request) Has been cancelled
Details
Preview Deploy / Deploy Preview Environment (pull_request) Has been cancelled
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m1s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m4s
Details
033bbf1ec3
xiaoxia added 1 commit 2026-07-27 12:44:48 +08:00
fix(upload-voice): GENDER_LABELS 补充 elderly 选项，修复 TS2741
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 7s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m29s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m1s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 1m2s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 38s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 24s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 1m45s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m16s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 36s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 53s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 57s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m46s
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been cancelled
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been cancelled
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
7603aeca5c
gitea-actions bot commented 2026-07-27 15:33:09 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #996
预览链接 https://pr-996.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #996 | | 预览链接 | [https://pr-996.preview.xiaoxiajianji.com](https://pr-996.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
xiaoxia added 1 commit 2026-07-27 15:35:23 +08:00
fix(upload-voice): Prettier 格式化 UploadDragger.tsx
CI/CD Pipeline / CI Gate (pull_request) CI运行中 [frontend-only]
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 17s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 56s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 42s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m56s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 2m8s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m12s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m51s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m9s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 44s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m44s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 5m18s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 8m1s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 27s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 20s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
4f3d7d3c1a
auto-approve-bot approved these changes 2026-07-27 17:56:54 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot approved these changes 2026-07-27 17:56:55 +08:00
auto-approve-bot left a comment
Collaborator
Copy Link
Copy Source

CI全绿，自动审批通过。

CI全绿，自动审批通过。
auto-approve-bot commented 2026-07-27 17:57:28 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #996

⚠️ 问题（0个需要修改）

💡 建议（2个可选）

  1. apps/web/src/pages/voices/components/upload-voice/UploadFormFields.tsx 第23行：GENDER_LABELS 常量中定义了 elderly: "老年音"，但在下方的渲染循环（第62行）中仅遍历了 ["female", "male", "child"]。如果 VoiceGender 类型包含 elderly，会导致该选项无法显示或选择；如果类型不包含，会导致 TypeScript 编译错误。建议根据业务需求补充遍历项或移除未使用的定义。
  2. apps/web/src/pages/voices/components/upload-voice/UploadActions.tsx 第28行：handleUploadClick 函数中包含了对 hasFile 和 hasName 的校验逻辑，但由于按钮已设置 disabled={!canUpload}（其中 canUpload 依赖这两个状态），在校验不通过时按钮本就不可点击。建议保留此校验作为防御性编程（以防未来逻辑变更），或者移除以减少冗余代码。

✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好

🤖 由 AI 代码审查机器人自动生成 | 2026-07-27 09:57:28 | 模型:

## 代码审查结果 - PR #996 ### ⚠️ 问题（0个需要修改） ### 💡 建议（2个可选） 1. **apps/web/src/pages/voices/components/upload-voice/UploadFormFields.tsx 第23行**：`GENDER_LABELS` 常量中定义了 `elderly: "老年音"`，但在下方的渲染循环（第62行）中仅遍历了 `["female", "male", "child"]`。如果 `VoiceGender` 类型包含 `elderly`，会导致该选项无法显示或选择；如果类型不包含，会导致 TypeScript 编译错误。建议根据业务需求补充遍历项或移除未使用的定义。 2. **apps/web/src/pages/voices/components/upload-voice/UploadActions.tsx 第28行**：`handleUploadClick` 函数中包含了对 `hasFile` 和 `hasName` 的校验逻辑，但由于按钮已设置 `disabled={!canUpload}`（其中 `canUpload` 依赖这两个状态），在校验不通过时按钮本就不可点击。建议保留此校验作为防御性编程（以防未来逻辑变更），或者移除以减少冗余代码。 --- ✅ 格式检查通过 | ✅ 逻辑审查通过 | ✅ 性能良好 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-27 09:57:28 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia closed this pull request 2026-07-27 18:03:40 +08:00
gitea-actions bot commented 2026-07-27 18:24:56 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #996 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #996 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / CI Gate (pull_request) CI运行中 [frontend-only]
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 17s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 56s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 42s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m56s
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 2m8s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 2m12s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 2m51s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 1m9s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 44s
Details
AI Code Review / AI Code Review (pull_request) Successful in 1m44s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 5m18s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 8m1s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 27s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 20s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
auto-approve-bot
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#996
Delete Branch "refactor/upload-voice-modal-split"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?