xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 11 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

refactor(wave113): 抽离transition_config领域模型 + 49单测 #999

Closed
xiaoxia wants to merge 1 commits from test/wave113-transition-config into develop
pull from: test/wave113-transition-config
merge into: xiaoxia:develop
Conversation 3 Commits 1 Files Changed 3
+529 -217
xiaoxia commented 2026-07-27 01:03:22 +08:00
Owner
Copy Link
Copy Source

变更内容

  • 新建 packages/domain/transition_config.py：纯逻辑配置层

    • TransitionType 枚举（14 种转场 + 10+ 别名映射，不区分大小写/下划线/中划线）
    • TransitionConfig 数据类（parse 解析 + is_cut / ffmpeg_transition / validate）
    • MIN_TRANSITION_DURATION / MAX_TRANSITION_DURATION / DEFAULT_TRANSITION_DURATION / CUT_TRANSITION 常量
    • StrEnum 兼容性处理（Python 3.10 及以下）

  • 精简 apps/worker/video_processing/transition_engine.py

    • 381→172行（-209行，-55%）
    • 枚举/数据类/常量/纯逻辑全部委托给 transition_config
    • 保留模块级导出，完全向后兼容

  • 新增 49 个单测（test_transition_config.py）

    • 常量验证（2 个）
    • TransitionType（10 个）：all_supported / is_supported 各种格式 / 别名 / 未知
    • TransitionConfig 默认值（3 个）
    • TransitionConfig.parse（19 个）：各种 effect + duration 边界 + 降级
    • ffmpeg_transition 映射（7 个）
    • validate 校验（7 个）

验证

  • 本地全绿：131 passed（82 原有 + 49 新增，含 transition_engine + transition_presets 全部测试）
  • black 格式化通过

关联

后端单测覆盖率提升 wave113，transition_engine 大文件拆分。

## 变更内容 - **新建** `packages/domain/transition_config.py`：纯逻辑配置层 - `TransitionType` 枚举（14 种转场 + 10+ 别名映射，不区分大小写/下划线/中划线） - `TransitionConfig` 数据类（`parse` 解析 + `is_cut` / `ffmpeg_transition` / `validate`） - `MIN_TRANSITION_DURATION` / `MAX_TRANSITION_DURATION` / `DEFAULT_TRANSITION_DURATION` / `CUT_TRANSITION` 常量 - StrEnum 兼容性处理（Python 3.10 及以下） - **精简** `apps/worker/video_processing/transition_engine.py` - 381→172行（-209行，**-55%**） - 枚举/数据类/常量/纯逻辑全部委托给 transition_config - 保留模块级导出，**完全向后兼容** - **新增** 49 个单测（test_transition_config.py） - 常量验证（2 个） - TransitionType（10 个）：all_supported / is_supported 各种格式 / 别名 / 未知 - TransitionConfig 默认值（3 个） - TransitionConfig.parse（19 个）：各种 effect + duration 边界 + 降级 - ffmpeg_transition 映射（7 个） - validate 校验（7 个） ## 验证 - 本地全绿：131 passed（82 原有 + 49 新增，含 transition_engine + transition_presets 全部测试） - black 格式化通过 ## 关联 后端单测覆盖率提升 wave113，transition_engine 大文件拆分。
xiaoxia added 1 commit 2026-07-27 01:03:23 +08:00
refactor(wave113): 抽离transition_config领域模型 + 49单测
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 25s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m3s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m56s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 38s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 56s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 34s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 45s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m2s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 53s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m10s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m0s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m29s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m20s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m48s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 19s
Details
254ad761b2 
- 新建 packages/domain/transition_config.py：纯逻辑配置层
  + TransitionType 枚举（14种转场 + 别名映射）
  + TransitionConfig 数据类（parse / is_cut / ffmpeg_transition / validate）
  + MIN/MAX/DEFAULT 时长常量 + CUT_TRANSITION 常量
- transition_engine.py: 381→172行 (-209行, -55%)
  保留模块级导出，完全向后兼容
- 新增 49 个单测覆盖枚举 + 数据类 + 纯逻辑
gitea-actions bot commented 2026-07-27 01:55:27 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #999
预览链接 https://pr-999.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #999 | | 预览链接 | [https://pr-999.preview.xiaoxiajianji.com](https://pr-999.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot commented 2026-07-27 01:56:17 +08:00
Collaborator
Copy Link
Copy Source

代码审查结果 - PR #999

⚠️ 问题（2个需要修改）

  1. packages/domain/transition_config.py 第168行：float(duration) 转换未处理 NaN 和 Infinity。

    • 原因：当 duration 为 float('nan') 或 float('inf') 时，后续的边界检查 d < MIN 和 d > MAX 均为 False，导致 NaN 被作为合法时长写入配置。
    • 后果：后续传给 FFmpeg 时可能导致未定义行为或渲染崩溃。
    • 建议：在 try 块中增加 math.isnan(d) 和 math.isinf(d) 的检查，或使用 d.is_integer() 等辅助判断，将非法数值钳制或使用默认值。

  2. packages/domain/transition_config.py 第236行：validate 方法对 None 和 NaN 的校验逻辑存在隐患。

    • 原因：代码直接使用 self.duration < MIN 进行比较。如果 self.duration 为 None（直接实例化时可能发生）会抛出 TypeError；如果是 NaN，比较结果为 False，导致校验错误地返回 (True, "")。
    • 后果：非法状态的对象通过校验，进入后续处理流程引发异常。
    • 建议：增加类型检查（isinstance(self.duration, (int, float))）和 NaN 检查。

💡 建议（2个可选）

  1. packages/domain/transition_config.py 第148行：建议增加 __post_init__ 方法以强化数据一致性。

    • 具体内容：当前 TransitionConfig 是 dataclass，允许绕过 parse 方法直接实例化（如 TransitionConfig(effect="invalid")）。这会导致 ffmpeg_transition 属性静默降级为 "fade"，而 validate 方法却返回 False，行为不一致。建议在 __post_init__ 中调用标准化逻辑，或将字段设为私有强制使用工厂方法。

  2. packages/domain/transition_config.py 第152行：effect 参数处理缺乏类型容错。

    • 具体内容：代码调用了 effect.strip()，如果传入非字符串类型（如 int），会抛出 AttributeError。虽然类型注解为 str | None，但考虑到 duration 参数做了 try/except 容错，建议此处也保持一致的防御性编程风格。

✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能良好

🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 17:56:17 | 模型:

## 代码审查结果 - PR #999 ### ⚠️ 问题（2个需要修改） 1. **packages/domain/transition_config.py 第168行**：`float(duration)` 转换未处理 `NaN` 和 `Infinity`。 - **原因**：当 `duration` 为 `float('nan')` 或 `float('inf')` 时，后续的边界检查 `d < MIN` 和 `d > MAX` 均为 False，导致 `NaN` 被作为合法时长写入配置。 - **后果**：后续传给 FFmpeg 时可能导致未定义行为或渲染崩溃。 - **建议**：在 `try` 块中增加 `math.isnan(d)` 和 `math.isinf(d)` 的检查，或使用 `d.is_integer()` 等辅助判断，将非法数值钳制或使用默认值。 2. **packages/domain/transition_config.py 第236行**：`validate` 方法对 `None` 和 `NaN` 的校验逻辑存在隐患。 - **原因**：代码直接使用 `self.duration < MIN` 进行比较。如果 `self.duration` 为 `None`（直接实例化时可能发生）会抛出 `TypeError`；如果是 `NaN`，比较结果为 False，导致校验错误地返回 `(True, "")`。 - **后果**：非法状态的对象通过校验，进入后续处理流程引发异常。 - **建议**：增加类型检查（`isinstance(self.duration, (int, float))`）和 NaN 检查。 ### 💡 建议（2个可选） 1. **packages/domain/transition_config.py 第148行**：建议增加 `__post_init__` 方法以强化数据一致性。 - **具体内容**：当前 `TransitionConfig` 是 dataclass，允许绕过 `parse` 方法直接实例化（如 `TransitionConfig(effect="invalid")`）。这会导致 `ffmpeg_transition` 属性静默降级为 "fade"，而 `validate` 方法却返回 False，行为不一致。建议在 `__post_init__` 中调用标准化逻辑，或将字段设为私有强制使用工厂方法。 2. **packages/domain/transition_config.py 第152行**：`effect` 参数处理缺乏类型容错。 - **具体内容**：代码调用了 `effect.strip()`，如果传入非字符串类型（如 `int`），会抛出 `AttributeError`。虽然类型注解为 `str | None`，但考虑到 `duration` 参数做了 `try/except` 容错，建议此处也保持一致的防御性编程风格。 --- ✅ 格式检查通过 | ❌ 逻辑审查需修改 | ✅ 性能良好 --- <sub>🤖 由 AI 代码审查机器人自动生成 | 2026-07-26 17:56:17 | 模型: </sub> <!-- AI_CODE_REVIEW_AUTO_COMMENT -->
xiaoxia closed this pull request 2026-07-27 15:26:22 +08:00
gitea-actions bot commented 2026-07-27 16:56:33 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #999 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #999 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 25s
Details
CI/CD Pipeline / Validate - Type Check (mypy) (pull_request) Successful in 1m3s
Details
CI/CD Pipeline / Validate - Code Quality (pull_request) Failing after 1m56s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 38s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Validate - Migration (alembic) (pull_request) Successful in 56s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Successful in 34s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 45s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 1m2s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 53s
Details
AI Code Review / AI Code Review (pull_request) Successful in 2m10s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m0s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m29s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m20s
Details
CI/CD Pipeline / Unit Tests (pull_request) Successful in 2m48s
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Has been skipped
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Has been cancelled
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 19s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#999
Delete Branch "test/wave113-transition-config"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?