xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 16 Pull Requests 10 Actions 34.2k Packages Projects Releases 7 Wiki Activity

fix(p0): from-assets空templateId双斜杠404兜底 #1921

Closed
xiaoxia wants to merge 4 commits from fix/p0-from-assets-default-template-fallback into develop
pull from: fix/p0-from-assets-default-template-fallback
merge into: xiaoxia:develop
Conversation 2 Commits 4 Files Changed 7
+365 -28
xiaoxia commented 2026-09-15 09:24:27 +08:00
Owner
Copy Link
Copy Source

已由 #1926 替代（分支重基到最新 develop，补充 16 个单元测试）

已由 #1926 替代（分支重基到最新 develop，补充 16 个单元测试）
xiaoxia added 1 commit 2026-09-15 09:24:27 +08:00
fix(p0): #1919 from-assets空templateId双斜杠404兜底
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 8s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 8s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 2m33s
Details
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 3m26s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 49s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 1m13s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m37s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m54s
Details
CI/CD Pipeline / Validate - Style (pull_request) Has been cancelled
Details
CI/CD Pipeline / Validate - Security (pull_request) Has been cancelled
Details
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
Details
CI/CD Pipeline / CI Gate (pull_request) Has been cancelled
Details
AI Code Review / AI Code Review (pull_request) Has been cancelled
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Has been cancelled
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 29h56m48s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 29h59m14s
Details
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Failing after 29h58m34s
Details
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Failing after 29h58m35s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 29h58m38s
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 29h58m38s
Details
CI/CD Pipeline / Check push changed paths (pull_request) Failing after 29h58m42s
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 29h55m10s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 29h55m52s
Details
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Failing after 29h58m34s
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 29h55m9s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 29h55m50s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 29h56m13s
Details
2d83b9385c 
根因：
1. PR#1918清理模板API时误删了GET /templates中自动创建默认模板的兜底逻辑
2. 前端PR#1913去掉空tid拦截后，首次进入生成页templateId为空，导致URL出现双斜杠
   /templates//editor/clips/from-assets → FastAPI返回404

修复：
1. 新增 routes/_default_template.py 共享 get_or_create_default_template_id()
2. GET /templates 在列表查询前调用兜底逻辑，保证新用户总能拿到默认模板
3. dependencies.py 抽出纯函数 resolve_draft_plan_id()，支持空tid自动兜底
4. 新增独立端点 POST /api/v1/clips/from-assets，template_id从body传入（可选）
   空时后端自动兜底，彻底规避双斜杠URL问题
5. 保留原 /templates/{template_id}/editor/clips/from-assets 路径兼容旧调用

前端改造指引：useStep2Materials 发from-assets请求时，空tid直接调用新端点
POST /api/v1/clips/from-assets，body中可选传template_id字段。
gitea-actions bot commented 2026-09-15 09:27:01 +08:00
Copy Link
Copy Source

🚀 预览环境已部署

项目 详情
PR号 #1921
预览链接 https://pr-1921.preview.xiaoxiajianji.com
API环境 staging

💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。

🔄 每次提交新代码后预览环境会自动更新。

🗑️ PR 关闭或合并后，预览环境会自动清理。

🚀 **预览环境已部署** | 项目 | 详情 | |------|------| | PR号 | #1921 | | 预览链接 | [https://pr-1921.preview.xiaoxiajianji.com](https://pr-1921.preview.xiaoxiajianji.com) | | API环境 | staging | > 💡 预览环境使用 staging API 数据，请勿在预览环境中操作重要数据。 > > 🔄 每次提交新代码后预览环境会自动更新。 > > 🗑️ PR 关闭或合并后，预览环境会自动清理。
auto-approve-bot added 1 commit 2026-09-15 09:29:18 +08:00
style: auto-format with black + isort + ruff + prettier [skip ci-format-check]
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 2s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 2s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m34s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m38s
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 2m56s
Details
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 3m27s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 3m26s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m31s
Details
AI Code Review / AI Code Review (pull_request) Successful in 6m45s
Details
CI/CD Pipeline / Validate - Security (pull_request) Successful in 9m23s
Details
CI/CD Pipeline / Validate - Style (pull_request) Failing after 16m8s
Details
PR Automation / Auto Approve on CI Green (pull_request) Failing after 16m9s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 3s
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Failing after 29h53m42s
Details
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Failing after 29h53m54s
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 29h54m21s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 29h53m12s
Details
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Failing after 29h53m19s
Details
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Failing after 29h53m19s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 29h53m38s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 29h53m45s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 29h53m46s
Details
CI/CD Pipeline / Check push changed paths (pull_request) Failing after 29h53m52s
Details
CI/CD Pipeline / Deploy Production (pull_request) Failing after 29h37m34s
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Failing after 29h37m35s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Failing after 29h37m35s
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Failing after 29h37m35s
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 29h53m7s
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Failing after 29h37m33s
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 29h53m7s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 29h53m40s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 29h53m41s
Details
a314a42405
xiaoxia added 1 commit 2026-09-15 10:15:13 +08:00
style: black+isort format p0 fix files [skip ci-format-check]
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 1s
Details
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 4s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 58s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 59s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m15s
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 3m3s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m49s
Details
CI/CD Pipeline / Validate - Style (pull_request) Successful in 3m36s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m52s
Details
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 6m11s
Details
AI Code Review / AI Code Review (pull_request) Successful in 6m29s
Details
CI/CD Pipeline / Validate - Security (pull_request) Successful in 9m48s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 2s
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 6m14s
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Failing after 28h58m29s
Details
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Failing after 29h7m28s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 29h8m27s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 29h7m47s
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 29h7m47s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 29h7m48s
Details
CI/CD Pipeline / Check push changed paths (pull_request) Failing after 29h7m53s
Details
CI/CD Pipeline / Deploy Production (pull_request) Failing after 28h57m51s
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Failing after 28h57m52s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Failing after 28h57m52s
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 29h6m40s
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Failing after 28h57m50s
Details
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Failing after 29h6m51s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 29h7m11s
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 29h6m40s
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Failing after 29h6m40s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 29h6m46s
Details
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Failing after 29h6m51s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 29h7m10s
Details
c243c4dd58
xiaoxia added 1 commit 2026-09-15 10:32:31 +08:00
test(p0): add unit tests for default template fallback (diff cov gate)
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 2s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 2s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m1s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 3m25s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 24s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 20s
Details
CI/CD Pipeline / Validate - Style (pull_request) Successful in 4m39s
Details
AI Code Review / AI Code Review (pull_request) Successful in 6m31s
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 3m45s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m12s
Details
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 4m57s
Details
CI/CD Pipeline / Validate - Security (pull_request) Successful in 11m11s
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 1s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 8m56s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 39s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 57s
Details
CI/CD Pipeline / Deploy Production (pull_request) Failing after 28h38m5s
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Failing after 28h46m40s
Details
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Failing after 28h46m58s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 28h47m24s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 28h50m35s
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 28h50m35s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 28h50m35s
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Failing after 28h37m29s
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Failing after 28h37m29s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Failing after 28h37m29s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 28h46m30s
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 28h46m3s
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 28h46m3s
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Failing after 28h37m27s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 28h46m9s
Details
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Failing after 28h46m21s
Details
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Failing after 28h46m21s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 28h46m47s
Details
CI/CD Pipeline / Check push changed paths (pull_request) Failing after 28h50m36s
Details
89e9e24a5e 
- 覆盖 resolve_draft_plan_id 空tid兜底/400/404/草稿复用/全局模板分支
- 满足 diff coverage ≥40% 门槛
xiaoxia closed this pull request 2026-09-15 11:37:53 +08:00
gitea-actions bot commented 2026-09-15 11:38:53 +08:00
Copy Link
Copy Source

🗑️ 预览环境已清理

PR #1921 已关闭或合并，对应的预览环境已被清理。

如有需要，可以重新打开 PR 来重新生成预览环境。

🗑️ **预览环境已清理** PR #1921 已关闭或合并，对应的预览环境已被清理。 > 如有需要，可以重新打开 PR 来重新生成预览环境。
Some checks are pending
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 2s
Details
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 2s
Details
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m1s
Details
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 3m25s
Details
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 24s
Details
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 20s
Details
CI/CD Pipeline / Validate - Style (pull_request) Successful in 4m39s
Details
AI Code Review / AI Code Review (pull_request) Successful in 6m31s
Details
CI/CD Pipeline / Unit Tests (pull_request) Failing after 3m45s
Details
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m12s
Details
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 4m57s
Details
CI/CD Pipeline / Validate - Security (pull_request) Successful in 11m11s
Details
CI/CD Pipeline / CI Gate (pull_request) Failing after 1s
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 8m56s
Details
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 39s
Details
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 57s
Details
CI/CD Pipeline / Deploy Production (pull_request) Failing after 28h38m5s
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Failing after 28h46m40s
Details
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Failing after 28h46m58s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 28h47m24s
Details
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 28h50m35s
Details
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 28h50m35s
Details
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 28h50m35s
Details
CI/CD Pipeline / Build Production Worker Image (pull_request) Failing after 28h37m29s
Details
CI/CD Pipeline / Build Production Web Image (pull_request) Failing after 28h37m29s
Details
CI/CD Pipeline / Build Production API Image (pull_request) Failing after 28h37m29s
Details
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 28h46m30s
Details
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 28h46m3s
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 28h46m3s
Details
CI/CD Pipeline / Canary Release to Production (pull_request) Failing after 28h37m27s
Details
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 28h46m9s
Details
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Failing after 28h46m21s
Details
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Failing after 28h46m21s
Details
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 28h46m47s
Details
CI/CD Pipeline / Check push changed paths (pull_request) Failing after 28h50m36s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
architecture
架构设计
 backend
后端相关
 blocked
阻塞中
 bug
Bug修复
 ci-bug
CI本身的bug
 ci-optimization
CI优化类任务
 ci-pipeline
CI流水线/workflow相关
 cleanup
代码清理
 devops
运维/部署/CI
 documentation
文档相关
 feature
新功能
 frontend
前端相关
 P0
阻塞性，必须立即处理
 P1
高优先级
 P2
中优先级
 P3
低优先级/后考虑
 question
需要讨论确认
 ready
PR CI通过，可合并
 refactor
代码重构
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
auto-approve-bot frontend-dev xiaoxia
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: xiaoxia/xiaoxia-saas#1921
Delete Branch "fix/p0-from-assets-default-template-fallback"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?