fix(p0): from-assets空templateId双斜杠404兜底 #1921

Closed
xiaoxia wants to merge 4 commits from fix/p0-from-assets-default-template-fallback into develop

4 Commits

Author SHA1 Message Date
灵应 89e9e24a5e test(p0): add unit tests for default template fallback (diff cov gate)
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 2s
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 2s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m1s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 3m25s
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 24s
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 20s
CI/CD Pipeline / Validate - Style (pull_request) Successful in 4m39s
AI Code Review / AI Code Review (pull_request) Successful in 6m31s
CI/CD Pipeline / Unit Tests (pull_request) Failing after 3m45s
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m12s
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 4m57s
CI/CD Pipeline / Validate - Security (pull_request) Successful in 11m11s
CI/CD Pipeline / CI Gate (pull_request) Failing after 1s
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 8m56s
ACR Cleanup / ACR Image Cleanup (pull_request_target) Successful in 39s
Preview Cleanup / Cleanup Preview Environment (pull_request) Successful in 57s
CI/CD Pipeline / Deploy Production (pull_request) Failing after 28h38m5s
CI/CD Pipeline / Staging E2E Tests (pull_request) Failing after 28h46m40s
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Failing after 28h46m58s
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 28h47m24s
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 28h50m35s
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 28h50m35s
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 28h50m35s
CI/CD Pipeline / Build Production Worker Image (pull_request) Failing after 28h37m29s
CI/CD Pipeline / Build Production Web Image (pull_request) Failing after 28h37m29s
CI/CD Pipeline / Build Production API Image (pull_request) Failing after 28h37m29s
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 28h46m30s
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 28h46m3s
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 28h46m3s
CI/CD Pipeline / Canary Release to Production (pull_request) Failing after 28h37m27s
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 28h46m9s
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Failing after 28h46m21s
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Failing after 28h46m21s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 28h46m47s
CI/CD Pipeline / Check push changed paths (pull_request) Failing after 28h50m36s
- 覆盖 resolve_draft_plan_id 空tid兜底/400/404/草稿复用/全局模板分支
- 满足 diff coverage ≥40% 门槛
2026-09-15 10:31:37 +08:00
灵应 c243c4dd58 style: black+isort format p0 fix files [skip ci-format-check]
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 1s
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 4s
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 58s
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 59s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m15s
CI/CD Pipeline / Unit Tests (pull_request) Failing after 3m3s
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m49s
CI/CD Pipeline / Validate - Style (pull_request) Successful in 3m36s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 2m52s
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 6m11s
AI Code Review / AI Code Review (pull_request) Successful in 6m29s
CI/CD Pipeline / Validate - Security (pull_request) Successful in 9m48s
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
CI/CD Pipeline / CI Gate (pull_request) Failing after 2s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Successful in 6m14s
CI/CD Pipeline / Build Production Worker Image (pull_request) Failing after 28h58m29s
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Failing after 29h7m28s
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 29h8m27s
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 29h7m47s
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 29h7m47s
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 29h7m48s
CI/CD Pipeline / Check push changed paths (pull_request) Failing after 29h7m53s
CI/CD Pipeline / Deploy Production (pull_request) Failing after 28h57m51s
CI/CD Pipeline / Build Production Web Image (pull_request) Failing after 28h57m52s
CI/CD Pipeline / Build Production API Image (pull_request) Failing after 28h57m52s
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 29h6m40s
CI/CD Pipeline / Canary Release to Production (pull_request) Failing after 28h57m50s
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Failing after 29h6m51s
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 29h7m11s
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 29h6m40s
CI/CD Pipeline / Staging E2E Tests (pull_request) Failing after 29h6m40s
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 29h6m46s
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Failing after 29h6m51s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 29h7m10s
2026-09-15 10:08:40 +08:00
CI Bot a314a42405 style: auto-format with black + isort + ruff + prettier [skip ci-format-check]
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 2s
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 2s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 1m34s
CI/CD Pipeline / Integration Tests (pull_request) Successful in 2m38s
CI/CD Pipeline / Unit Tests (pull_request) Failing after 2m56s
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 3m27s
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 3m26s
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 3m31s
AI Code Review / AI Code Review (pull_request) Successful in 6m45s
CI/CD Pipeline / Validate - Security (pull_request) Successful in 9m23s
CI/CD Pipeline / Validate - Style (pull_request) Failing after 16m8s
PR Automation / Auto Approve on CI Green (pull_request) Failing after 16m9s
PR Automation / Auto Merge on CI Green + Approved (pull_request) Has been skipped
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
CI/CD Pipeline / CI Gate (pull_request) Failing after 3s
CI/CD Pipeline / Staging E2E Tests (pull_request) Failing after 29h53m42s
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Failing after 29h53m54s
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 29h54m21s
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 29h53m12s
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Failing after 29h53m19s
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Failing after 29h53m19s
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 29h53m38s
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 29h53m45s
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 29h53m46s
CI/CD Pipeline / Check push changed paths (pull_request) Failing after 29h53m52s
CI/CD Pipeline / Deploy Production (pull_request) Failing after 29h37m34s
CI/CD Pipeline / Build Production Worker Image (pull_request) Failing after 29h37m35s
CI/CD Pipeline / Build Production API Image (pull_request) Failing after 29h37m35s
CI/CD Pipeline / Build Production Web Image (pull_request) Failing after 29h37m35s
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 29h53m7s
CI/CD Pipeline / Canary Release to Production (pull_request) Failing after 29h37m33s
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 29h53m7s
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 29h53m40s
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 29h53m41s
2026-09-15 01:29:14 +00:00
灵应 2d83b9385c fix(p0): #1919 from-assets空templateId双斜杠404兜底
CI/CD Pipeline / Dedup Check - skip PR tests when covered by push pipeline (pull_request) Successful in 8s
CI/CD Pipeline / Check if frontend-only change (pull_request) Successful in 8s
Preview Deploy / Deploy Preview Environment (pull_request) Successful in 2m33s
CI/CD Pipeline / Validate - Python (mypy + alembic) (pull_request) Successful in 3m26s
CI/CD Pipeline / PR Build Worker Image (pull_request) Successful in 49s
CI/CD Pipeline / PR Build API Image (pull_request) Successful in 1m13s
CI/CD Pipeline / Integration Tests (pull_request) Successful in 3m37s
PR Automation / Auto Approve on CI Green (pull_request) Successful in 3m54s
CI/CD Pipeline / Validate - Style (pull_request) Has been cancelled
CI/CD Pipeline / Validate - Security (pull_request) Has been cancelled
CI/CD Pipeline / Unit Tests (pull_request) Has been cancelled
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been cancelled
CI/CD Pipeline / Build Production API Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production Web Image (pull_request) Has been cancelled
CI/CD Pipeline / Build Production Worker Image (pull_request) Has been cancelled
CI/CD Pipeline / Deploy Production (pull_request) Has been cancelled
CI/CD Pipeline / Production Browser E2E (pull_request) Has been cancelled
CI/CD Pipeline / Canary Release to Production (pull_request) Has been cancelled
CI/CD Pipeline / CI Gate (pull_request) Has been cancelled
AI Code Review / AI Code Review (pull_request) Has been cancelled
PR Automation / Auto Merge on CI Green + Approved (pull_request) Has been cancelled
CI/CD Pipeline / Frontend Unit Tests (pull_request) Failing after 29h56m48s
CI/CD Pipeline / Build Staging API Image (pull_request) Failing after 29h59m14s
CI/CD Pipeline / Retag skipped Staging Web Image (pull_request) Failing after 29h58m34s
CI/CD Pipeline / Retag skipped Staging API Image (pull_request) Failing after 29h58m35s
CI/CD Pipeline / Build Staging Worker Image (pull_request) Failing after 29h58m38s
CI/CD Pipeline / Build Staging Web Image (pull_request) Failing after 29h58m38s
CI/CD Pipeline / Check push changed paths (pull_request) Failing after 29h58m42s
CI/CD Pipeline / Staging API Integration Tests (pull_request) Failing after 29h55m10s
CI/CD Pipeline / PR Build Web Image (pull_request) Failing after 29h55m52s
CI/CD Pipeline / Retag skipped Staging Worker Image (pull_request) Failing after 29h58m34s
CI/CD Pipeline / ACR Image Cleanup (pull_request) Failing after 29h55m9s
CI/CD Pipeline / Deploy Staging (Watchtower auto-deploy) (pull_request) Failing after 29h55m50s
CI/CD Pipeline / Frontend Lint (pull_request) Failing after 29h56m13s
根因:
1. PR#1918清理模板API时误删了GET /templates中自动创建默认模板的兜底逻辑
2. 前端PR#1913去掉空tid拦截后,首次进入生成页templateId为空,导致URL出现双斜杠
   /templates//editor/clips/from-assets → FastAPI返回404

修复:
1. 新增 routes/_default_template.py 共享 get_or_create_default_template_id()
2. GET /templates 在列表查询前调用兜底逻辑,保证新用户总能拿到默认模板
3. dependencies.py 抽出纯函数 resolve_draft_plan_id(),支持空tid自动兜底
4. 新增独立端点 POST /api/v1/clips/from-assets,template_id从body传入(可选)
   空时后端自动兜底,彻底规避双斜杠URL问题
5. 保留原 /templates/{template_id}/editor/clips/from-assets 路径兼容旧调用

前端改造指引:useStep2Materials 发from-assets请求时,空tid直接调用新端点
POST /api/v1/clips/from-assets,body中可选传template_id字段。
2026-09-15 09:22:01 +08:00