xiaoxia/xiaoxia-saas
1
0
Fork 0
Code Issues 9 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

fix: 一键生成 P0 修复 + P1 校验 #203

Merged
xiaoxia merged 4 commits from fix/oneclick-gen-p0-fixes into develop 2026-07-10 09:27:02 +08:00
Conversation 4 Commits 4 Files Changed 5
+914 -69

4 Commits

Author SHA1 Message Date
用户CI Test ad5036c93a fix: 删除 _validate_asset_ids_ownership 死代码函数
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 55s
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 1m23s
Details
CI/CD Pipeline / Build & Push Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Runtime Images (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details 
代码审计发现 commit 6d1f4da1 只删了测试用例，函数本体（53行）和注释引用仍残留。

本次修复：
- 删除 _validate_asset_ids_ownership 函数（原第489-538行，53行死代码）
- 更新第391行注释，移除对已删函数的引用
- grep 全仓库确认无其他引用
- 单测 27 passed，无回归

归属校验逻辑已在 P3-2 优化中合并进 _download_library_assets 的同一 DB session。
 2026-07-10 09:19:06 +08:00
用户CI Test 6d1f4da112 refactor: 删除 _validate_asset_ids_ownership 死代码函数
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 41s
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 1m30s
Details
CI/CD Pipeline / Build & Push Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Runtime Images (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details 
该函数已在 P3-2 优化中合并到 _download_library_assets，不再被调用。
同时删除 test_oneclick_gen_p0_fixes.py 中对应的 5 个测试用例，
归属校验覆盖已由 test_generation_p3_optimizations.py 提供。
 2026-07-10 08:33:18 +08:00
用户CI Test ab413413b7 perf(P3): 三项代码审查优化 — strict模式/session合并/HEAD重试
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 1m34s
Details
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 1m47s
Details
CI/CD Pipeline / Build & Push Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Runtime Images (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details 
P3-1: _download_library_assets 增加 strict 参数（默认 true）
  - strict 模式：任意素材下载失败立即抛 RuntimeError
  - non-strict 模式：跳过失败素材返回成功列表，全部失败仍抛异常
  - 归属校验合并到同一 DB session（P3-2），减少连接开销

P3-2: 移除 generate_video 中独立的 _validate_asset_ids_ownership 调用
  - 归属校验已内联到 _download_library_assets 同一 session 中

P3-3: _verify_url_accessible 增加 HEAD 重试（默认 2 次，间隔 1s）
  - 防止 OSS 抖动导致误报不可访问

新增 15 个单元测试覆盖三项优化
更新 1 个旧测试适配新 strict 模式错误信息

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
 2026-07-10 07:42:39 +08:00
用户CI Test c947abc038 fix: 一键生成 P0 修复 + P1 校验
CI/CD Pipeline / Validate Code Quality And Tests (pull_request) Successful in 1m10s
Details
CI/CD Pipeline / Frontend Lint (pull_request) Successful in 3m40s
Details
CI/CD Pipeline / Build & Push Staging (Watchtower auto-deploy) (pull_request) Has been skipped
Details
CI/CD Pipeline / Build Production Runtime Images (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging E2E Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Staging API Integration Tests (pull_request) Has been skipped
Details
CI/CD Pipeline / Deploy Production (pull_request) Has been skipped
Details
CI/CD Pipeline / Production Browser E2E (pull_request) Has been skipped
Details 
P0-1: _download_library_assets 支持双模式查询（asset_library_id / project_id）
       下载失败时抛出 RuntimeError，不再静默忽略
P0-2: OSS 上传失败抛异常 + 上传后 HEAD 校验 URL 可访问性
P0-3: run_ffmpeg 失败时完整 stderr 打到日志（排查 exit code 183）
       _execute_ffmpeg 额外记录 filter_complex 便于诊断
P1:   template_id 存在性校验（不存在/已禁用 → ValueError）
       asset_ids 归属校验（不属于指定项目/素材库 → ValueError）

新增 16 个单元测试覆盖全部修复点，全量 1170 测试通过无回归
 2026-07-10 00:28:47 +08:00